Skip to content

needless_for_each FN when for_each is in the expr of a block #16294

@profetia

Description

@profetia

Summary

needless_for_each FN when for_each is in the expr of a block

Lint Name

needless_for_each

Reproducer

I tried this code:

fn foo() {
    let vec: Vec<i32> = Vec::new();
    vec.iter().for_each(|elem| {
        println!("{elem}");
    })
}

I expected to see this happen:

Lint trigger on the for_each

Instead, this happened:

Nothing happened

Version

rustc 1.94.0-nightly (f52090008 2025-12-10)
binary: rustc
commit-hash: f5209000832c9d3bc29c91f4daef4ca9f28dc797
commit-date: 2025-12-10
host: x86_64-unknown-linux-gnu
release: 1.94.0-nightly
LLVM version: 21.1.5

Metadata

Metadata

Assignees

Labels

C-bugCategory: Clippy is not doing the correct thingI-false-negativeIssue: The lint should have been triggered on code, but wasn't

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions