From 0d2ff68adeaa464a06d41b15a160ea69d4f57619 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Rakic?= Date: Fri, 18 Jul 2025 12:27:56 +0000 Subject: [PATCH 1/4] be consistent about secondary rfc reviews --- src/TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/TEMPLATE.md b/src/TEMPLATE.md index e8242bdf..16f90264 100644 --- a/src/TEMPLATE.md +++ b/src/TEMPLATE.md @@ -80,7 +80,7 @@ | Author RFC | *Goal point of contact, typically* | | | Lang-team champion | ![Team][] [lang] | Username here | | RFC decision | ![Team][] [lang] | | -| Secondary RFC review | ![Team][] [types] | request bandwidth from a second team, most features don't need this | +| RFC secondary review | ![Team][] [types] | request bandwidth from a second team, most features don't need this | ### Implement language feature X @@ -125,7 +125,7 @@ For definitions for terms used above, see the [About > Team Asks](https://rust-l * *Design meeting* means holding a synchronous meeting to review a proposal and provide feedback (no decision expected). * *RFC decisions* means reviewing an RFC and deciding whether to accept. * *Org decisions* means reaching a decision on an organizational or policy matter. -* *Secondary review* of an RFC means that the team is "tangentially" involved in the RFC and should be expected to briefly review. +* *RFC secondary review* means that the team is "tangentially" involved in the RFC and should be expected to briefly review. * *Stabilizations* means reviewing a stabilization and report and deciding whether to stabilize. * *Standard reviews* refers to reviews for PRs against the repository; these PRs are not expected to be unduly large or complicated. * *Prioritized nominations* refers to prioritized lang-team response to nominated issues, with the expectation that there will be *some* response from the next weekly triage meeting. From 26b47d0e6a6495e7f12cb130da310c3224e75659 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Rakic?= Date: Fri, 18 Jul 2025 12:30:57 +0000 Subject: [PATCH 2/4] fix plurals and words --- src/TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/TEMPLATE.md b/src/TEMPLATE.md index 16f90264..a1cc8c4b 100644 --- a/src/TEMPLATE.md +++ b/src/TEMPLATE.md @@ -123,13 +123,13 @@ For definitions for terms used above, see the [About > Team Asks](https://rust-l * *Discussion and moral support* is the lowest level offering, basically committing the team to nothing but good vibes and general support for this endeavor. * *Author RFC* and *Implementation* means actually writing the code, document, whatever. * *Design meeting* means holding a synchronous meeting to review a proposal and provide feedback (no decision expected). -* *RFC decisions* means reviewing an RFC and deciding whether to accept. -* *Org decisions* means reaching a decision on an organizational or policy matter. +* *RFC decision* means reviewing an RFC and deciding whether to accept. +* *Org decision* means reaching a decision on an organizational or policy matter. * *RFC secondary review* means that the team is "tangentially" involved in the RFC and should be expected to briefly review. -* *Stabilizations* means reviewing a stabilization and report and deciding whether to stabilize. +* *Stabilization decision* means reviewing a stabilization and report and deciding whether to stabilize. * *Standard reviews* refers to reviews for PRs against the repository; these PRs are not expected to be unduly large or complicated. * *Prioritized nominations* refers to prioritized lang-team response to nominated issues, with the expectation that there will be *some* response from the next weekly triage meeting. -* *Dedicated review* means identifying an individual (or group of individuals) who will review the changes, as they're expected to require significant context. +* *Dedicated reviewer* means identifying an individual (or group of individuals) who will review the changes, as they're expected to require significant context. * Other kinds of decisions: * [Lang team experiments](https://lang-team.rust-lang.org/how_to/experiment.html) are used to add nightly features that do not yet have an RFC. They are limited to trusted contributors and are used to resolve design details such that an RFC can be written. * Compiler [Major Change Proposal (MCP)](https://forge.rust-lang.org/compiler/mcp.html) is used to propose a 'larger than average' change and get feedback from the compiler team. From 887a1c7eecacce4f0a9075b558cf019d50c3aab2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Rakic?= Date: Fri, 18 Jul 2025 12:31:41 +0000 Subject: [PATCH 3/4] these don't seem to be a thing --- src/TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/TEMPLATE.md b/src/TEMPLATE.md index a1cc8c4b..94ce5394 100644 --- a/src/TEMPLATE.md +++ b/src/TEMPLATE.md @@ -128,7 +128,6 @@ For definitions for terms used above, see the [About > Team Asks](https://rust-l * *RFC secondary review* means that the team is "tangentially" involved in the RFC and should be expected to briefly review. * *Stabilization decision* means reviewing a stabilization and report and deciding whether to stabilize. * *Standard reviews* refers to reviews for PRs against the repository; these PRs are not expected to be unduly large or complicated. -* *Prioritized nominations* refers to prioritized lang-team response to nominated issues, with the expectation that there will be *some* response from the next weekly triage meeting. * *Dedicated reviewer* means identifying an individual (or group of individuals) who will review the changes, as they're expected to require significant context. * Other kinds of decisions: * [Lang team experiments](https://lang-team.rust-lang.org/how_to/experiment.html) are used to add nightly features that do not yet have an RFC. They are limited to trusted contributors and are used to resolve design details such that an RFC can be written. From 84a4d0ec7bd5838580b145d8537fd728f48bceaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Rakic?= Date: Fri, 18 Jul 2025 16:29:32 +0000 Subject: [PATCH 4/4] Heap wanted --- src/TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TEMPLATE.md b/src/TEMPLATE.md index 94ce5394..ab94465e 100644 --- a/src/TEMPLATE.md +++ b/src/TEMPLATE.md @@ -61,7 +61,7 @@ > > *For most goals, a single table will suffice, but you can also add subsections with `###`. We give several example subsections below that also demonstrate the most common kinds of goals. Remember that the items in the table only corresponds to what you plan to do over the next 6 months.* > -> *For items done by a contributor, list the contributor, or ![Heap wanted][] if you don't yet know who will do it. The owner is ideally identified as a github username like `@ghost`.* +> *For items done by a contributor, list the contributor, or ![Help wanted][] if you don't yet know who will do it. The owner is ideally identified as a github username like `@ghost`.* > > *For items asked of teams, list ![Team][] and the name of the team, e.g. `![Team][] [compiler]` or `![Team][] [compiler], [lang]` (note the trailing `[]` in `![Team][]`, that is needed for markdown to parse correctly). For team asks, the "task" must be one of the tasks defined in [rust-project-goals.toml](../rust-project-goals.toml) or `cargo rpg check` will error.*