Skip to content

Conversation

@lolbinarycat
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 21, 2025
@GuillaumeGomez
Copy link
Member

Arf, more work for my rustdoc attribute conversion (you can see it here). T_T

Thanks in any case for the improvement! r=me once CI pass

@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-bad-render-attr branch from 827f24c to 39b7b91 Compare November 21, 2025 21:49
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-bad-render-attr branch from 39b7b91 to b962f49 Compare November 22, 2025 20:47
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-bad-render-attr branch from b962f49 to 2ee6196 Compare November 23, 2025 18:00
@lolbinarycat
Copy link
Contributor Author

@bors r=@GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

📌 Commit 2ee6196 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2025
bors added a commit that referenced this pull request Nov 23, 2025
Rollup of 3 pull requests

Successful merges:

 - #149179 (Add regression test for 128705)
 - #149197 (validate usage of crate-level doc attributes)
 - #149232 (Add doc aliases "vector" and "list" to `Vec`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fdcf1f2 into rust-lang:main Nov 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 24, 2025
rust-timer added a commit that referenced this pull request Nov 24, 2025
Rollup merge of #149197 - lolbinarycat:rustdoc-bad-render-attr, r=GuillaumeGomez

validate usage of crate-level doc attributes

fixes #149187

r? `@GuillaumeGomez`
@bors
Copy link
Collaborator

bors commented Nov 24, 2025

⌛ Testing commit 2ee6196 with merge d3e1ccd...

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 24, 2025
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#149179 (Add regression test for 128705)
 - rust-lang/rust#149197 (validate usage of crate-level doc attributes)
 - rust-lang/rust#149232 (Add doc aliases "vector" and "list" to `Vec`)

r? `@ghost`
`@rustbot` modify labels: rollup
@lolbinarycat lolbinarycat added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc does not warn about misuse of html render option attributes

5 participants