Merge pull request #2194 from rust-lang/revert-2188-dont-panic-s3

Revert "Do not panic on S3 file upload failures"

Author: Kobzol

collector/src/compile/execute/bencher.rs

@@ -338,9 +338,9 @@ impl SelfProfileS3Upload {
         let start = std::time::Instant::now();
         let status = self.0.wait().expect("waiting for child");
         if !status.success() {
-            log::error!("S3 upload failed: {status:?}");
-        } else {
-            log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
+            panic!("S3 upload failed: {:?}", status);
         }
+
+        log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
     }
 }