Skip to content

Commit 67a2940

Browse files
committed
Do not panic on S3 file upload failures
1 parent 71dfcd1 commit 67a2940

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

collector/src/compile/execute/bencher.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,9 @@ impl SelfProfileS3Upload {
345345
let start = std::time::Instant::now();
346346
let status = self.0.wait().expect("waiting for child");
347347
if !status.success() {
348-
panic!("S3 upload failed: {:?}", status);
348+
log::error!("S3 upload failed: {status:?}");
349+
} else {
350+
log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
349351
}
350-
351-
log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
352352
}
353353
}

0 commit comments

Comments
 (0)