Skip to content

Commit f920e05

Browse files
lqdlqd
authored
Merge pull request #2349 from rust-lang/panstromek-patch-1
Add triage for 2025-12-08
2 parents c51fdd0 + 2b8d67a commit f920e05

File tree

1 file changed

+120
-0
lines changed

1 file changed

+120
-0
lines changed

‎triage/2025/2025-12-08.md‎

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
# 2025-12-08 Triage Log
2+
3+
Overall result is negative this week, but both main regressions are on track to be addressed. No outstanding changes otherwise.
4+
5+
Triage done by **@panstromek**.
6+
Revision range: [eca9d93f..55495234](https://perf.rust-lang.org/?start=eca9d93f9057f9a48ff691bd65e7daf2f94c1b67&end=554952348a7dd13851f25789f6bb1061f45c4b60&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 4.3%] | 111 |
13+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 2.2%] | 97 |
14+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.3%, -0.7%] | 2 |
15+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.0%] | 9 |
16+
| All ❌✅ (primary) | 0.4% | [-1.3%, 4.3%] | 113 |
17+
18+
19+
3 Regressions, 2 Improvements, 3 Mixed; 3 of them in rollups
20+
30 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 12 pull requests [#149631](https://github.com/rust-lang/rust/pull/149631) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=556beb9ec72360512d0294eb0855c92fb2c20c88&end=b1b08cdef5ed3bca71c0d6638fccadc90d2e0ea3&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:-------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | - | - | 0 |
29+
| Regressions ❌ <br /> (secondary) | 7.4% | [0.1%, 25.0%] | 10 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | - | - | 0 |
33+
34+
Caused by https://github.com/rust-lang/rust/pull/149147, reverted in https://github.com/rust-lang/rust/pull/149657.
35+
36+
Add `#[inline]` to `Layout::is_size_align_valid` [#149690](https://github.com/rust-lang/rust/pull/149690) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa301763000fd65db235b2d6e4c04da99abf8cd8&end=1d6c526bb010900bc1fd4c45c4ef0307b5150583&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:----:|:------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 1.2% | [0.1%, 4.3%] | 4 |
41+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.2%, 2.2%] | 8 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 1.2% | [0.1%, 4.3%] | 4 |
45+
46+
Little regression matches pre-merge run, justified by https://github.com/rust-lang/rust/pull/149690#issuecomment-3620152210
47+
48+
early return on duplicate span lowerings [#149060](https://github.com/rust-lang/rust/pull/149060) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1d6c526bb010900bc1fd4c45c4ef0307b5150583&end=fa1f706fbd0fd1c02763ecb28915bf23c860cb32&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:----:|:------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.8%] | 70 |
53+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.0%, 0.8%] | 73 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
56+
| All ❌✅ (primary) | 0.3% | [0.1%, 0.8%] | 70 |
57+
58+
Regression is unexpected, results don't match pre-merge results. Reverted in https://github.com/rust-lang/rust/pull/149757.
59+
60+
#### Improvements
61+
62+
misc coercion cleanups and handle safety correctly [#148602](https://github.com/rust-lang/rust/pull/148602) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=864339abf952f07098dd82610256338520167d4a&end=97b131c90059e6122f22562ab4d78d50160daeff&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | - | - | 0 |
69+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.5%, -0.1%] | 13 |
70+
| All ❌✅ (primary) | - | - | 0 |
71+
72+
73+
Revert "Rollup merge of #149147 - chenyukang:yukang-fix-unused_assignments-macro-gen-147648, r=JonathanBrouwer" [#149657](https://github.com/rust-lang/rust/pull/149657) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d427ddfe90367eaa6d2ed7bb8a16559f0230f47a&end=1c5a0cfc13559b863b47b64b51429360fe55ef73&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:---------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | - | - | 0 |
80+
| Improvements ✅ <br /> (secondary) | -7.0% | [-20.0%, -0.6%] | 9 |
81+
| All ❌✅ (primary) | - | - | 0 |
82+
83+
84+
#### Mixed
85+
86+
Rollup of 5 pull requests [#149560](https://github.com/rust-lang/rust/pull/149560) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=646a3f8c15baefb98dc6e0c1c1ba3356db702d2a&end=a4cfac7093a1c1c7fbdb6bc75d6b6dc4d385fc69&stat=instructions:u)
87+
88+
| (instructions:u) | mean | range | count |
89+
|:----------------------------------:|:-----:|:--------------:|:-----:|
90+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
91+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
92+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.1%] | 2 |
93+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
94+
| All ❌✅ (primary) | -0.2% | [-0.6%, 0.1%] | 3 |
95+
96+
I supect the doc regression is mostly noise. Either way, I don't think it's worth more investigation, it's just a doc and it's small.
97+
98+
Rollup of 9 pull requests [#149646](https://github.com/rust-lang/rust/pull/149646) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b33119ffdd483969934b10a886dc06dd29a473f9&end=3e2dbcdd3a4fc1b5aabfcd0c401c093734e72df2&stat=instructions:u)
99+
100+
| (instructions:u) | mean | range | count |
101+
|:----------------------------------:|:-----:|:--------------:|:-----:|
102+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 30 |
103+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.4%] | 7 |
104+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 2 |
105+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 6 |
106+
| All ❌✅ (primary) | 0.2% | [-0.4%, 0.3%] | 32 |
107+
108+
Based on the results above, the regression seems to be caused by https://github.com/rust-lang/rust/pull/149524. After looking through other PRs, I don't think there's any other candidate. I left a comment on the PR. Author will investigate.
109+
110+
TypeRelating emit WellFormed, not generalize [#148823](https://github.com/rust-lang/rust/pull/148823) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=36b2369c91d32c2659887ed6fe3d570640f44fd2&end=b4f1098e10e71139bbdc08df5ea8183e68fc0955&stat=instructions:u)
111+
112+
| (instructions:u) | mean | range | count |
113+
|:----------------------------------:|:-----:|:--------------:|:-----:|
114+
| Regressions ❌ <br /> (primary) | - | - | 0 |
115+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.0%, 0.5%] | 14 |
116+
| Improvements ✅ <br /> (primary) | -1.3% | [-1.3%, -1.3%] | 1 |
117+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 8 |
118+
| All ❌✅ (primary) | -1.3% | [-1.3%, -1.3%] | 1 |
119+
120+
post-merge results look worse on secondary benchmarks, compared to pre-merge run. The final result still is positive, but only because of 1 primary bechmark. I looked through the secondary regressions and most of them returned back to previous state in next PR, so this is probably noise.

0 commit comments

Comments
 (0)