Merge pull request #734 from FractalFir/remove_needless_attr

antoyo · web-flow · commit 35bdf8b4e22a · 2025-07-09T17:10:02.000-04:00
Skip needlessly setting the default visibility on functions
diff --git a/src/mono_item.rs b/src/mono_item.rs
@@ -64,7 +64,7 @@ impl<'gcc, 'tcx> PreDefineCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
         if linkage != Linkage::Internal && self.tcx.is_compiler_builtins(LOCAL_CRATE) {
             #[cfg(feature = "master")]
             decl.add_attribute(FnAttribute::Visibility(gccjit::Visibility::Hidden));
-        } else {
+        } else if visibility != Visibility::Default {
             #[cfg(feature = "master")]
             decl.add_attribute(FnAttribute::Visibility(base::visibility_to_gcc(visibility)));
         }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ impl<'gcc, 'tcx> PreDefineCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> {`
`64`	`64`	`if linkage != Linkage::Internal && self.tcx.is_compiler_builtins(LOCAL_CRATE) {`
`65`	`65`	`#[cfg(feature = "master")]`
`66`	`66`	`decl.add_attribute(FnAttribute::Visibility(gccjit::Visibility::Hidden));`
`67`		`- } else {`
	`67`	`+ } else if visibility != Visibility::Default {`
`68`	`68`	`#[cfg(feature = "master")]`
`69`	`69`	`decl.add_attribute(FnAttribute::Visibility(base::visibility_to_gcc(visibility)));`
`70`	`70`	`}`