clippy

Author: hashemix

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.89.0"
+channel = "1.88.0"
 components = ["rustfmt", "clippy"]

src/cli.rs

@@ -1,4 +1,4 @@
-use clap::{arg, command, Parser};
+use clap::{Parser, arg, command};
 
 #[derive(Parser, Debug)]
 #[command(name =  env!("CARGO_PKG_NAME"))]
@@ -30,9 +30,10 @@ pub struct CommandArguments {
 impl CommandArguments {
     pub fn validate(&self) -> Result<(), String> {
         if !self.enable_roots && self.allowed_directories.is_empty() {
-            return Err(
-                format!(" <ALLOWED_DIRECTORIES> is required when `--enable-roots` is not provided.\n Run `{} --help` to view the usage instructions.",env!("CARGO_PKG_NAME"))
-            );
+            return Err(format!(
+                " <ALLOWED_DIRECTORIES> is required when `--enable-roots` is not provided.\n Run `{} --help` to view the usage instructions.",
+                env!("CARGO_PKG_NAME")
+            ));
         }
         Ok(())
     }

src/error.rs

@@ -1,7 +1,7 @@
 use async_zip::error::ZipError;
 use glob::PatternError;
-use rust_mcp_sdk::schema::{schema_utils::SdkError, RpcError};
-use rust_mcp_sdk::{error::McpSdkError, TransportError};
+use rust_mcp_sdk::schema::{RpcError, schema_utils::SdkError};
+use rust_mcp_sdk::{TransportError, error::McpSdkError};
 
 use thiserror::Error;
 use tokio::io;
@@ -10,7 +10,9 @@ pub type ServiceResult<T> = core::result::Result<T, ServiceError>;
 
 #[derive(Debug, Error)]
 pub enum ServiceError {
-    #[error("Service is running in read-only mode. To enable write access, please run with the --allow-write flag.")]
+    #[error(
+        "Service is running in read-only mode. To enable write access, please run with the --allow-write flag."
+    )]
     NoWriteAccess,
     #[error("{0}")]
     FromString(String),

src/fs_service.rs

@@ -10,10 +10,10 @@ use glob::Pattern;
 use grep::{
     matcher::{Match, Matcher},
     regex::RegexMatcherBuilder,
-    searcher::{sinks::UTF8, BinaryDetection, Searcher},
+    searcher::{BinaryDetection, Searcher, sinks::UTF8},
 };
 use rust_mcp_sdk::schema::RpcError;
-use serde_json::{json, Value};
+use serde_json::{Value, json};
 use similar::TextDiff;
 use std::{
     collections::HashSet,
@@ -568,14 +568,12 @@ impl FileSystemService {
                 if root_path == entry.path() {
                     return false;
                 }
-
-                let is_match = glob_pattern
+                glob_pattern
                     .as_ref()
                     .map(|glob| {
                         glob.matches(&entry.file_name().to_str().unwrap_or("").to_lowercase())
                     })
-                    .unwrap_or(false);
-                is_match
+                    .unwrap_or(false)
             });
 
         Ok(result)

src/fs_service/utils.rs

@@ -4,7 +4,7 @@ use std::{
     time::SystemTime,
 };
 
-use async_zip::{error::ZipError, tokio::write::ZipFileWriter, Compression, ZipEntryBuilder};
+use async_zip::{Compression, ZipEntryBuilder, error::ZipError, tokio::write::ZipFileWriter};
 use chrono::{DateTime, Local};
 use dirs::home_dir;
 

src/handler.rs

@@ -100,16 +100,16 @@ impl FileSystemHandler {
                     vec![]
                 } else {
                     let roots: Vec<_> = roots.iter().map(|v| v.uri.as_str()).collect();
-                    let valid_roots = match fs_service.valid_roots(roots) {
+
+                    match fs_service.valid_roots(roots) {
                         Ok((roots, skipped)) => {
                             if let Some(message) = skipped {
                                 let _ = runtime.stderr_message(message.to_string()).await;
                             }
                             roots
                         }
                         Err(_err) => vec![],
-                    };
-                    valid_roots
+                    }
                 };
 
                 if valid_roots.is_empty() && !mcp_roots_support {

src/server.rs

@@ -1,8 +1,8 @@
 use rust_mcp_sdk::schema::{
-    Implementation, InitializeResult, ServerCapabilities, ServerCapabilitiesTools,
-    LATEST_PROTOCOL_VERSION,
+    Implementation, InitializeResult, LATEST_PROTOCOL_VERSION, ServerCapabilities,
+    ServerCapabilitiesTools,
 };
-use rust_mcp_sdk::{mcp_server::server_runtime, McpServer, StdioTransport, TransportOptions};
+use rust_mcp_sdk::{McpServer, StdioTransport, TransportOptions, mcp_server::server_runtime};
 
 use crate::handler::FileSystemHandler;
 use crate::{cli::CommandArguments, error::ServiceResult};

src/tools/create_directory.rs

@@ -1,8 +1,8 @@
 use std::path::Path;
 
-use rust_mcp_sdk::macros::{mcp_tool, JsonSchema};
+use rust_mcp_sdk::macros::{JsonSchema, mcp_tool};
 use rust_mcp_sdk::schema::TextContent;
-use rust_mcp_sdk::schema::{schema_utils::CallToolError, CallToolResult};
+use rust_mcp_sdk::schema::{CallToolResult, schema_utils::CallToolError};
 
 use crate::fs_service::FileSystemService;
 

src/tools/directory_tree.rs

@@ -1,7 +1,7 @@
-use rust_mcp_sdk::macros::{mcp_tool, JsonSchema};
+use rust_mcp_sdk::macros::{JsonSchema, mcp_tool};
 use rust_mcp_sdk::schema::TextContent;
-use rust_mcp_sdk::schema::{schema_utils::CallToolError, CallToolResult};
-use serde_json::{json, Map, Value};
+use rust_mcp_sdk::schema::{CallToolResult, schema_utils::CallToolError};
+use serde_json::{Map, Value, json};
 
 use crate::error::ServiceError;
 use crate::fs_service::FileSystemService;

src/tools/edit_file.rs

@@ -1,8 +1,8 @@
 use std::path::Path;
 
-use rust_mcp_sdk::macros::{mcp_tool, JsonSchema};
+use rust_mcp_sdk::macros::{JsonSchema, mcp_tool};
 use rust_mcp_sdk::schema::TextContent;
-use rust_mcp_sdk::schema::{schema_utils::CallToolError, CallToolResult};
+use rust_mcp_sdk::schema::{CallToolResult, schema_utils::CallToolError};
 
 use crate::fs_service::FileSystemService;