Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

npm install in chapter-zero warns of high severity vulnerabilities #32

@reillysiemens

Description

@reillysiemens

Describe the bug
Running the initial npm installon the chapter-zero branch results in a warning about high severity vulnerabilities.

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/rustwasm/wasm_game_of_life.git
  2. cd wasm_game_of_life
  3. git checkout -b chapter-zero origin/chapter-zero
  4. npm install

Expected behavior
npm install requires no audit fixes to install JavaScript dependencies without warning.

Screenshots
npm-package-security-advisories

Additional context
In this case the vulnerabilities I saw were actually just one vulnerability that was filed recently and has already been patched. It's no trouble to run npm audit fix, but I think that slows readers down. Worrying about whether they need to take care of vulnerabilities might detract from the goal of learning about WebAssembly and Rust.

For what it's worth, I'm using

  • nvm - v0.33.11
  • Node.js - v10.9.0
  • npm - v6.4.0
  • Git - v2.17.1

I believe this can be easily resolved by running the audit fixes and the committing the updated package-lock.json, but I've no idea what effect that will have on the branching structure for the repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions