Skip to content

Commit 59bd298

Browse files
committed
fix: resolve remaining CI issues
- Add missing React hook dependencies in QuickFilterDropdown - Add explicit permissions to sync-agent-status workflow to fix security issue
1 parent c0082bc commit 59bd298

File tree

4 files changed

+35
-13
lines changed

4 files changed

+35
-13
lines changed

.github/workflows/sync-agent-status.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ on:
77
types: [labeled, unlabeled, opened, closed, reopened]
88
workflow_dispatch:
99

10+
permissions:
11+
contents: read
12+
issues: write
13+
pull-requests: write
14+
1015
jobs:
1116
sync-agent-status:
1217
runs-on: ubuntu-latest

package-lock.json

Lines changed: 26 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,5 +182,8 @@
182182
},
183183
"overrides": {
184184
"prismjs": "^1.30.0"
185+
},
186+
"dependencies": {
187+
"ag-grid-react-components": "^0.1.0"
185188
}
186189
}

src/components/QuickFilterDropdown/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export const QuickFilterDropdown: React.FC<QuickFilterDropdownProps> = ({
121121
} catch (error) {
122122
console.warn("[QuickFilterDropdown] Error getting active filter:", error);
123123
}
124-
}, [api, columnId, allOptions]);
124+
}, [api, columnId, allOptions, enablePresets, presets]);
125125

126126
// Calculate dropdown position (only used when portal is enabled)
127127
const calculateDropdownPosition = useCallback(() => {

0 commit comments

Comments
 (0)