Skip to content

Commit b3c1742

Browse files
authored
Merge pull request #124 from lt-schmidt-jr/master
Issue #123 update grpc to version 1.24 protoc to version 3.9.1
2 parents d682eae + fa7319d commit b3c1742

File tree

5 files changed

+26
-17
lines changed

5 files changed

+26
-17
lines changed

contrib/grpc-spring/src/main/java/com/salesforce/grpc/contrib/spring/GuavaLFReturnValueHandler.java

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.google.common.util.concurrent.FutureCallback;
1212
import com.google.common.util.concurrent.Futures;
1313
import com.google.common.util.concurrent.ListenableFuture;
14+
import com.google.common.util.concurrent.MoreExecutors;
1415
import org.springframework.core.MethodParameter;
1516
import org.springframework.web.context.request.NativeWebRequest;
1617
import org.springframework.web.context.request.async.DeferredResult;
@@ -70,17 +71,19 @@ public void handleReturnValue(Object returnValue, MethodParameter returnType, Mo
7071
final DeferredResult<Object> deferredResult = new DeferredResult<>();
7172
@SuppressWarnings("unchecked")
7273
ListenableFuture<Object> futureValue = (ListenableFuture<Object>) returnValue;
73-
Futures.addCallback(futureValue, new FutureCallback<Object>() {
74-
@Override
75-
public void onSuccess(@Nullable Object result) {
76-
deferredResult.setResult(result);
77-
}
74+
Futures.addCallback(futureValue,
75+
new FutureCallback<Object>() {
76+
@Override
77+
public void onSuccess(@Nullable Object result) {
78+
deferredResult.setResult(result);
79+
}
7880

79-
@Override
80-
public void onFailure(Throwable ex) {
81-
deferredResult.setErrorResult(ex);
82-
}
83-
});
81+
@Override
82+
public void onFailure(Throwable ex) {
83+
deferredResult.setErrorResult(ex);
84+
}
85+
},
86+
MoreExecutors.directExecutor());
8487

8588
startDeferredResultProcessing(mavContainer, webRequest, deferredResult);
8689
}

contrib/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<mavenBaseUrl>https://oss.sonatype.org/content/repositories</mavenBaseUrl>
6060

6161
<!-- Dependency Versions -->
62-
<grpc.version>1.12.0</grpc.version>
63-
<protoc.version>3.5.1</protoc.version> <!-- Same version as grpc-proto -->
62+
<grpc.version>1.24.0</grpc.version>
63+
<protoc.version>3.9.1</protoc.version> <!-- Same version as grpc-proto -->
6464
<slf4j.version>1.7.21</slf4j.version>
6565
<gson.version>2.7</gson.version> <!-- Same version as grpc-proto -->
6666
<mustache-java.version>0.9.4</mustache-java.version>

demos/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<contrib.version>0.8.1</contrib.version>
6060
<jprotoc.version>0.8.1</jprotoc.version>
6161

62-
<grpc.version>1.12.0</grpc.version>
63-
<protoc.version>3.5.1</protoc.version> <!-- Same version as grpc-proto -->
62+
<grpc.version>1.24.0</grpc.version>
63+
<protoc.version>3.9.1</protoc.version> <!-- Same version as grpc-proto -->
6464
<slf4j.version>1.7.21</slf4j.version>
6565
<gson.version>2.7</gson.version> <!-- Same version as grpc-proto -->
6666
<mustache-java.version>0.9.4</mustache-java.version>

jprotoc/jprotoc/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@
3131
<groupId>com.google.code.gson</groupId>
3232
<artifactId>gson</artifactId>
3333
</dependency>
34+
<dependency>
35+
<groupId>com.google.protobuf</groupId>
36+
<artifactId>protobuf-java-util</artifactId>
37+
<version>${protoc.version}</version>
38+
</dependency>
39+
3440
<!-- Test dependencies -->
3541
<dependency>
3642
<groupId>junit</groupId>

jprotoc/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@
5858
<mavenBaseUrl>https://oss.sonatype.org/content/repositories</mavenBaseUrl>
5959

6060
<!-- Dependency Versions -->
61-
<contrib.version>0.8.1</contrib.version>
61+
<contrib.version>0.8.2-SNAPSHOT</contrib.version>
6262

63-
<grpc.version>1.12.0</grpc.version>
64-
<protoc.version>3.5.1</protoc.version> <!-- Same version as grpc-proto -->
63+
<grpc.version>1.24.0</grpc.version>
64+
<protoc.version>3.9.1</protoc.version> <!-- Same version as grpc-proto -->
6565
<slf4j.version>1.7.21</slf4j.version>
6666
<gson.version>2.7</gson.version> <!-- Same version as grpc-proto -->
6767
<mustache-java.version>0.9.4</mustache-java.version>

0 commit comments

Comments
 (0)