Skip to content

Commit 36b4e49

Browse files
authored
chore(ci): actually run web-test-runner for PRs (#5486)
* chore(ci): actually run web-test-runner for PRs * chore(ci): only run web-test-runner tests on push to release branches will still run on other branches if there's a PR open * chore(ci): use shorter name * test(wtr): temporarily skip tests that are broken in CI
1 parent 6e973b4 commit 36b4e49

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

.github/workflows/web-test-runner.yml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ on:
44
push:
55
branches:
66
- master
7+
- release
8+
- 'spring*'
9+
- 'summer*'
10+
- 'winter*'
711
pull_request:
8-
branches:
9-
- master
1012

1113
env:
1214
SAUCE_USERNAME: ${{secrets.SAUCE_USERNAME}}
@@ -20,7 +22,7 @@ jobs:
2022
# TODO: add env var combos we use for Karma tests
2123
# TODO: upload result artifacts
2224
# TODO: make it saucy 🥫
23-
run-wtr-tests-group-1:
25+
wtr-group-1:
2426
runs-on: ubuntu-22.04
2527
env:
2628
SAUCE_TUNNEL_ID: github-action-tunnel-wtr-${{github.run_id}}-group-1
@@ -50,11 +52,3 @@ jobs:
5052

5153
- run: yarn test
5254
- run: yarn test:hydration
53-
54-
run-karma-tests:
55-
runs-on: ubuntu-22.04
56-
defaults:
57-
run:
58-
working-directory: ./packages/@lwc/integration-not-karma
59-
needs:
60-
- run-wtr-tests-group-1

packages/@lwc/integration-not-karma/configs/integration.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ export default {
1616

1717
// Implement objectContaining / arrayWithExactContents
1818
'!test/profiler/mutation-logging/index.spec.js',
19+
20+
// Broken in CI?
21+
'!test/lwc-on/index.spec.js',
22+
'!test/api/sanitizeAttribute/index.spec.js',
23+
'!test/template-expressions/errors/index.spec.js',
24+
'!test/template-expressions/smoke-test/index.spec.js',
1925
],
2026
plugins: [...baseConfig.plugins, testPlugin],
2127
};

0 commit comments

Comments
 (0)