Skip to content

host_javabase is deprecated #294

@juanmarin-co

Description

@juanmarin-co

Since bazel 5.0 the parameter used here is deprecated:

host_javabase = find_java_runtime_toolchain(ctx, ctx.attr._host_javabase),

Generating the following error:

Traceback (most recent call last):
	File "/home/juan/.cache/bazel/_bazel_juan/7e6e30ecb52b472e0900bbc0b820a797/external/com_salesforce_servicelibs_reactive_grpc/bazel/java_reactive_grpc_library.bzl", line 71, column 36, in _reactive_grpc_library_impl
		java_info = java_common.compile(
Error in compile: in call to compile(), parameter 'host_javabase' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_java_common_parameters=false

The documentation suggests that it can be just dropped:
image

Do you find any risk on doing this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions