Merge pull request rubocop#931 from r7kamura/feature/presense-multiline-ternary

Fix error in `Rails/Presence` when ternary operators are used in multiple lines

Author: koic

changelog/fix_error_in_rails_presence_when_ternary.md

@@ -0,0 +1 @@
+* [#931](https://github.com/rubocop/rubocop-rails/pull/931): Fix error in `Rails/Presence` when ternary operators are used in multiple lines. ([@r7kamura][])

lib/rubocop/cop/rails/presence.rb

@@ -112,10 +112,10 @@ def message(node, receiver, other)
         end
 
         def current(node)
-          if node.source.include?("\n")
+          if !node.ternary? && node.source.include?("\n")
             "#{node.loc.keyword.with(end_pos: node.condition.loc.selector.end_pos).source} ... end"
           else
-            node.source
+            node.source.gsub(/\n\s*/, ' ')
           end
         end
 

spec/rubocop/cop/rails/presence_spec.rb

@@ -233,6 +233,21 @@
     RUBY
   end
 
+  context 'when multiline ternary can be replaced' do
+    it 'registers an offense and corrects' do
+      expect_offense(<<~RUBY)
+        a.present? ?
+        ^^^^^^^^^^^^ Use `a.presence` instead of `a.present? ? a : nil`.
+          a :
+          nil
+      RUBY
+
+      expect_correction(<<~RUBY)
+        a.presence
+      RUBY
+    end
+  end
+
   context 'when a method argument of `else` branch is enclosed in parentheses' do
     it 'registers an offense and corrects' do
       expect_offense(<<~RUBY)