Potentially fix some issues loading app states.

This was motivated by a user report of app getting into a state where the app became unusable, due to loading an invalid state - however, I dont know if this work will actually fix the issue.  The issue was happening in JS, however, I think the JS error was related to a c++ exception causing not everything to be loaded.  I was able to
Have not fixed all potential issues.

Made so InterSpec::loadState c++ has more granular try/catchs, and tried re-arranging order of operations a little so changes to the GUI isnt as intertwined with the DB code, although this is still the case to a good extent.
Fixed issue of loading Act/Shield state that could cause inconsistencies, due to checks being applied to GUI state before it was fully deserialized.
Also added some JS try/catch around the spectrum calls to JS, since this is where the error showed up, but adding these protections are unlikely to be very useful.

Author: wcjohns

InterSpec/InterSpecApp.h

@@ -266,9 +266,7 @@ class InterSpec_API InterSpecApp : public Wt::WApplication
   /** Adds `m_activeTimeSinceDbUpdate` to the database, saving the updated result. */
   void updateUsageTimeToDb();
 
-#if(  BUILD_AS_WX_WIDGETS_APP )
   virtual void handleJavaScriptError( const std::string &errorText );
-#endif
 
 #if( !BUILD_FOR_WEB_DEPLOYMENT )
   /** Checks for URL argument "externalid", or equivalently "apptoken", and if found sets m_externalToken to it.

InterSpec/InterSpecUser.h

@@ -770,7 +770,7 @@ struct UserState
   int backgroundId;
   int secondForegroundId;
   int shieldSourceModelId;
-  std::string otherSpectraCsvIds;
+  std::string otherSpectraCsvIds; //!< TODO: This doesnt look to be used; should add option to save all other open files to the database when saving a state; noting which are part of saved app states or not
   std::string foregroundSampleNumsCsvIds;
   std::string secondForegroundSampleNumsCsvIds;
   std::string backgroundSampleNumsCsvIds;

InterSpec/ShieldingSourceDisplay.h

@@ -372,10 +372,9 @@ class ShieldingSourceDisplay : public Wt::WContainerWidget
    
    @param before If nullptr, the shielding will be added after the last ShieldingSelect; if non-null, the new ShieldingSelect will be added
                 before the specified ShieldingSelect.
-   @param updateChiChartAndAddUndoRedo If true, the Chi2 chart will be updated after adding, AND a undo/redo point will be
-                added.
+   @param addUndoRedo If true, an undo/redo point will be added.
   */
-  ShieldingSelect *addShielding( ShieldingSelect *before, const bool updateChiChartAndAddUndoRedo );
+  ShieldingSelect *addShielding( ShieldingSelect *before, const bool addUndoRedo );
 
   //doAddShielding(), doAddShieldingBefore(), doAddShieldingAfter:
   //  convience functions that calls addShielding(...) appropriately.
@@ -468,9 +467,17 @@ class ShieldingSourceDisplay : public Wt::WContainerWidget
   //  std::exception on error, with a message approprtiate for output to user.
   void checkAndWarnZeroMassFraction();
 
-  //checkDistanceAndThicknessConsistent(): called when the m_distanceEdit is
-  //  changed; makes sure radius of outer shielding is less than this distnace,
-  //  and updates chi2 chart
+  /** Called when doing a model fit, the geometry changes, or when updating the Chi2 chart due to dimension or
+   shielding/material changes (this update happens during the `Wt::render(...)` call), to make sure radius of
+   outer shielding is less than the detector distance, and other characteristics of the shielding are consistent with the
+   model.
+   This function also updates the fit model activities of for volumetric sources.
+   
+   Note: this function should only be called when the whole GUI state is completely setup.
+   For example, if you first set shielding thicknesses, then call this function, then set detector distance, you
+   could have caused the shielding thicknesses to have been changed based on the old detector distances.
+   This also applies to other properties like which thicknesses are allowed to be fit.
+   */
   void checkDistanceAndThicknessConsistent();
 
   /** Checks to see if fitting for more than one atomic number of generic shielding.

src/D3SpectrumDisplayDiv.cpp

@@ -577,7 +577,7 @@ void D3SpectrumDisplayDiv::setShowPeakLabel( int label, bool show )
 {
   SpectrumChart::PeakLabels peakLabel = SpectrumChart::PeakLabels(label);
 
-  string js = m_jsgraph;
+  string js = "try{" + m_jsgraph;
   switch( peakLabel )
   {
     case SpectrumChart::PeakLabels::kShowPeakUserLabel:
@@ -598,6 +598,7 @@ void D3SpectrumDisplayDiv::setShowPeakLabel( int label, bool show )
       break;
   }
   js += "(" + jsbool(show) + ");";
+  js += "}catch(e){ console.error('Error showing peak labels:',e); }";
 
   m_peakLabelsToShow[peakLabel] = show;
 
@@ -711,8 +712,16 @@ void D3SpectrumDisplayDiv::clearAllReferncePhotoPeakLines()
   m_persistedPhotoPeakLines.clear();
 
   if( isRendered() )
-    doJavaScript(m_jsgraph + ".clearReferenceLines();");
-}
+  {
+    // Will add try/catch to this call as a debug measure, for a problem in another location
+    doJavaScript(
+      "try{"
+        + m_jsgraph + ".clearReferenceLines();"
+       "}catch(e){"
+         "console.error('Error clearing ref lines',e);"
+        "}");
+  }//if( isRendered() )
+}//void clearAllReferncePhotoPeakLines()
 
 
 void D3SpectrumDisplayDiv::setReferenceLinesToClient()
@@ -937,23 +946,44 @@ void D3SpectrumDisplayDiv::showGridLines( bool show )
   m_showVerticalLines = show;
   m_showHorizontalLines = show;
   if( isRendered() )
-    doJavaScript( m_jsgraph + ".setGridX(" + jsbool(show) + ");"
-                  + m_jsgraph + ".setGridY(" + jsbool(show) + ");" );
-}
+  {
+    doJavaScript( 
+      "try{"
+      + m_jsgraph + ".setGridX(" + jsbool(show) + ");"
+      + m_jsgraph + ".setGridY(" + jsbool(show) + ");"
+      "}catch(e){"
+        "console.error('showGridLines error:',e);"
+      "}");
+  }
+}//showGridLines(...)
 
 void D3SpectrumDisplayDiv::showVerticalLines( const bool draw )
 {
   m_showVerticalLines = draw;
   if( isRendered() )
-    doJavaScript( m_jsgraph + ".setGridX(" + jsbool(draw) + ");" );
-}
+  {
+    doJavaScript(
+      "try{"
+      + m_jsgraph + ".setGridX(" + jsbool(draw) + ");"
+      "}catch(e){"
+        "console.error('showVerticalLines error:',e);"
+      "}" );
+  }
+}//showVerticalLines( const bool draw )
 
 void D3SpectrumDisplayDiv::showHorizontalLines( const bool draw )
 {
   m_showHorizontalLines = draw;
   if( isRendered() )
-    doJavaScript( m_jsgraph + ".setGridY(" + jsbool(draw) + ");" );
-}
+  {
+    doJavaScript(
+      "try{"
+      + m_jsgraph + ".setGridY(" + jsbool(draw) + ");"
+      "}catch(e){"
+        "console.error('showHorizontalLines error:',e);"
+      "}" );
+  }
+}//showHorizontalLines( const bool draw )
 
 bool D3SpectrumDisplayDiv::verticalLinesShowing() const
 {