Skip to content

Commit bad197a

Browse files
committed
Fix some smaller display issues.
Scroll bars where they shouldn't be, wording, etc.
1 parent 427cd2c commit bad197a

File tree

8 files changed

+52
-27
lines changed

8 files changed

+52
-27
lines changed

InterSpec_resources/DbFileBrowser.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
.SnapshotTable
88
{
99
padding: 2px;
10+
overflow-x: hidden;
1011
}
1112

1213

InterSpec_resources/ShieldingSourceDisplay.css

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,26 @@
5252
}
5353

5454

55+
.DetAndMenu
56+
{
57+
display: flex;
58+
flex-wrap: nowrap;
59+
align-items: center;
60+
justify-content: space-between;
61+
}
5562

63+
.DetAndMenu .DetectorDisplay
64+
{
65+
flex: 1 1 content;
66+
}
5667

5768
.RoundMenuIcon,.RoundMenuIcon:hover
5869
{
5970
background-image: url('../InterSpec_resources/images/menu_icon_round.svg');
60-
background-position: 3px center;
71+
/* background-position: 3px center; */
6172
background-repeat: no-repeat;
62-
padding-left: 23px; /* width of the image plus a little extra padding */
73+
/* padding-left: 23px; */ /* width of the image plus a little extra padding */
74+
width: 26px;
6375
background-color: rgba(0,0,0,0) !important;
6476
border: none;
6577
}

InterSpec_resources/static_text/make_drf_help.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Some comments on taking test-source data:
105105
and other effects. Very roughly, scintillating detectors (NaI, LaBr, etc)
106106
should probably have less than about 20% dead-time, while HPGe should
107107
have less than about 50% dead-time, although acceptable levels will be
108-
system dependant.
108+
system dependent.
109109
</li>
110110
<li>Test-sources should be at least 25 cm away from the detector so that
111111
gammas striking the detector are about parallel.
@@ -280,6 +280,13 @@ def getFWHM( energy ):
280280
You can also choose to show this fit and peak FWHM data on the chart by selecting the
281281
&quot;Show FWHM points&quot; checkbox.
282282
</div>
283+
<div style="margin-top: 10px;">
284+
When the &quot;<span style="font-weight: bold;">Atten. for air</span>&quot; option is checked, the source distance will be used to
285+
compensate for the gamma attenuation in the air. It is recommended to have this option checked
286+
unless your measurements will always be at the same distance as the calibration-measurements (in
287+
which case you should also disable air attenuation from the &quot;Activity/Shielding Fit&quot; tool;
288+
however, leaving it enabled in both places would cancel out anyway).
289+
</div>
283290
</p>
284291
</div>
285292

src/DecayWindow.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,9 @@ DecayWindow::DecayWindow( InterSpec *viewer )
5151
(Wt::WFlags<AuxWindowProperties>(AuxWindowProperties::DisableCollapse) | AuxWindowProperties::EnableResize) ),
5252
m_activityDiv( 0 )
5353
{
54-
WContainerWidget *contentDiv = WDialog::contents();
5554
m_activityDiv = new DecayActivityDiv( viewer );
5655

57-
WGridLayout *layout = new WGridLayout();
58-
contentDiv->setLayout( layout );
56+
WGridLayout *layout = stretcher();
5957
layout->addWidget( m_activityDiv, 0, 0 );
6058
layout->setContentsMargins( 0, 0, 0, 0 );
6159
layout->setVerticalSpacing( 0 );

src/MakeDrf.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1577,10 +1577,10 @@ AuxWindow *MakeDrf::makeDrfWindow( InterSpec *viewer, MaterialDB *materialDB, Wt
15771577

15781578
AuxWindow::addHelpInFooter( window->footer(), "make-drf" );
15791579

1580-
WPushButton *closeButton = window->addCloseButtonToFooter( "Cancel" );
1580+
WPushButton *closeButton = window->addCloseButtonToFooter( "Close" );
15811581
closeButton->clicked().connect( window, &AuxWindow::hide );
15821582

1583-
WPushButton *saveAs = new WPushButton( "Save As...", window->footer() );
1583+
WPushButton *saveAs = new WPushButton( "Store/Export...", window->footer() );
15841584
saveAs->clicked().connect( makeDrfWidget, &MakeDrf::startSaveAs );
15851585
makeDrfWidget->intrinsicEfficiencyIsValid().connect( boost::bind( &WPushButton::setEnabled, saveAs, _1 ) );
15861586
saveAs->disable();

src/PeakSearchGuiUtils.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,9 +337,9 @@ class PeakSelectorWindow : public AuxWindow
337337
}//if( m_showAllPeaks )
338338

339339

340-
// The rel eff chart is close, but not fully debugged, so leaving diabled for now
340+
// The rel eff chart is close, but not fully debugged, so leaving disabled for now
341341
//setupRelEffChart();
342-
342+
contents()->setOverflow( WContainerWidget::Overflow::OverflowAuto, Orientation::Vertical );
343343
m_table = new WTable( contents() );
344344
m_table->addStyleClass( "PeakSelectorTable" );
345345
m_table->setHeaderCount( 1, Wt::Horizontal );

src/ShieldingSelect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1984,7 +1984,7 @@ void ShieldingSelect::init()
19841984

19851985
lbltxt = fistShield ? "Radius" : "Radial Thickness";
19861986
setupDimEdit( lbltxt, m_cylRadiusEdit, m_fitCylRadiusCB, cylindricalLayout );
1987-
lbltxt = fistShield ? "Length" : "Length Thickness";
1987+
lbltxt = fistShield ? "Half-Length" : "Length Thickness";
19881988
setupDimEdit( lbltxt, m_cylLengthEdit, m_fitCylLengthCB, cylindricalLayout );
19891989

19901990

src/ShieldingSourceDisplay.cpp

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2574,7 +2574,7 @@ ShieldingSourceDisplay::ShieldingSourceDisplay( PeakModel *peakModel,
25742574
m_shieldingSelects = new WContainerWidget();
25752575
m_shieldingSelects->setStyleClass( "ShieldingSelectContainer" );
25762576

2577-
tooltip = "Shieldings are treated as spherical shells with the innermost"
2577+
tooltip = "Shieldings are treated as shells with the innermost"
25782578
" shell being the first one you add (the top one in this box), and"
25792579
" the subsequent shieldings layered around that one. Any sources"
25802580
" not attributed as components of shieldings are treated as point"
@@ -2872,30 +2872,37 @@ if (m_specViewer->isSupportFile())
28722872
chartDiv->setLayout(chartLayout);
28732873
chartLayout->setContentsMargins(0, 0, 0, 0);
28742874

2875-
chartLayout->addWidget( m_detectorDisplay, 0, 0, AlignLeft );
2876-
chartLayout->addWidget( m_showChiOnChart, 0, 1 );
2877-
chartLayout->addWidget( addItemMenubutton, 0, 2, AlignRight);
2878-
chartLayout->addWidget( m_chi2Graphic, 1, 0, 1, 3 );
2879-
chartLayout->addWidget( m_fitModelButton, 2, 0, 1, 3, AlignCenter );
2880-
chartLayout->addWidget( m_fitProgressTxt, 3, 0, 1 ,3, AlignCenter );
2875+
chartLayout->addWidget( m_detectorDisplay, 0, 0, AlignLeft );
2876+
chartLayout->addWidget( m_showChiOnChart, 0, 1 );
2877+
chartLayout->addWidget( addItemMenubutton, 0, 2, AlignRight);
2878+
chartLayout->addWidget( m_chi2Graphic, 1, 0, 1, 3 );
2879+
chartLayout->addWidget( m_fitModelButton, 2, 0, 1, 3, AlignCenter );
2880+
chartLayout->addWidget( m_fitProgressTxt, 3, 0, 1 ,3, AlignCenter );
28812881
chartLayout->addWidget( m_cancelfitModelButton, 4, 0, 1, 3, AlignCenter );
28822882

28832883
chartLayout->setRowStretch(1, 1);
28842884
tab->addTab(chartDiv,"Fit", Wt::WTabWidget::PreLoading);
28852885
}else
28862886
{
28872887
//regular layout
2888-
detectorLayout->addWidget( m_detectorDisplay, 0, 0 );
2889-
detectorLayout->addWidget( addItemMenubutton, 0, 1 );
2890-
detectorLayout->addWidget( smallerContainer, 1, 0, 1, 2);
2891-
detectorLayout->addWidget( m_shieldingSelects, 2, 0, 1, 2 );
2892-
detectorLayout->addWidget( m_fitModelButton, 3, 0, 1, 2, AlignCenter );
2893-
detectorLayout->addWidget( m_fitProgressTxt, 4, 0, 1, 2 );
2894-
detectorLayout->addWidget( m_cancelfitModelButton, 5, 0, 1, 2, AlignCenter );
2895-
detectorLayout->addWidget( m_showChi2Text, 6, 0, 1, 2 );
2888+
2889+
// We'll put the detector and menu icon in a flexbox layout, which is less hassle than
2890+
// the Wt layout
2891+
WContainerWidget *toprow = new WContainerWidget();
2892+
toprow->addStyleClass( "DetAndMenu" );
2893+
toprow->addWidget( m_detectorDisplay );
2894+
toprow->addWidget( addItemMenubutton );
2895+
2896+
2897+
detectorLayout->addWidget( toprow, 0, 0 );
2898+
detectorLayout->addWidget( smallerContainer, 1, 0 );
2899+
detectorLayout->addWidget( m_shieldingSelects, 2, 0 );
2900+
detectorLayout->addWidget( m_fitModelButton, 3, 0, AlignCenter );
2901+
detectorLayout->addWidget( m_fitProgressTxt, 4, 0 );
2902+
detectorLayout->addWidget( m_cancelfitModelButton, 5, 0, AlignCenter );
2903+
detectorLayout->addWidget( m_showChi2Text, 6, 0 );
28962904

28972905
detectorLayout->setRowStretch( 2, 1 );
2898-
detectorLayout->setColumnStretch( 0, 1 );
28992906
detectorLayout->setHorizontalSpacing( 0 );
29002907
detectorLayout->setVerticalSpacing( 0 );
29012908
detectorLayout->setContentsMargins( 1, 1, 1, 1 );

0 commit comments

Comments
 (0)