Refactor JdbcAdmin

[brfrn169]

Description

This PR refactors JdbcAdmin to improve maintainability and extensibility.

Related issues and/or PRs

N/A

Changes made

• Extracted table metadata operations from JdbcAdmin into TableMetadataService
• Extracted namespace metadata operations from JdbcAdmin into NamespaceMetadataService
• Updated tests to reference the new service classes for metadata constants and methods

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the JdbcAdmin class within the JDBC storage implementation. The primary goal is to enhance modularity and maintainability by extracting metadata management responsibilities into two specialized service classes: TableMetadataService and NamespaceMetadataService. This change centralizes metadata-related logic, simplifies the JdbcAdmin class, and ensures a clearer separation of concerns, making the codebase easier to understand and extend.

Highlights

• Refactoring JdbcAdmin: The core JdbcAdmin class has been significantly refactored to improve modularity and separation of concerns. Metadata management logic has been extracted into new dedicated service classes.
• New Metadata Services: Two new classes, TableMetadataService and NamespaceMetadataService, have been introduced. TableMetadataService handles operations related to table metadata (e.g., creating, deleting, retrieving table schemas), while NamespaceMetadataService manages namespace-specific metadata (e.g., creating, dropping, and checking namespace existence).
• Code Simplification and Delegation: The JdbcAdmin class is now much leaner, delegating all metadata-related SQL query generation and execution to the newly created services. This reduces the complexity of JdbcAdmin and centralizes metadata logic.
• Test Updates: All relevant integration and unit tests have been updated to reflect the refactoring, ensuring that the new metadata services are correctly utilized and the functionality remains robust.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the JdbcAdmin class by extracting metadata management logic into new TableMetadataService and NamespaceMetadataService classes. This is a good improvement for separation of concerns. The review has identified a few potential issues with the refactored logic, including missing checks in corner cases like upgrading a fresh environment or dropping the last namespace, which could lead to unexpected behavior or metadata loss. There is also a minor issue where a schema is assumed to exist before a table is created, which could make the code more fragile.

[Copilot]

Pull Request Overview

This PR refactors the JDBC admin code by extracting table and namespace metadata management logic into dedicated service classes (TableMetadataService and NamespaceMetadataService), improving code organization and separation of concerns.

• Extracted table metadata operations from JdbcAdmin into TableMetadataService
• Extracted namespace metadata operations from JdbcAdmin into NamespaceMetadataService
• Updated tests to reference the new service classes for metadata constants and methods

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
JdbcAdmin.java	Refactored to use new metadata service classes, reducing class size and improving modularity
TableMetadataService.java	New service class handling all table metadata operations
NamespaceMetadataService.java	New service class handling all namespace metadata operations
JdbcAdminTest.java	Updated test to reference new service classes and removed unused test helper and variables
JdbcOperationCheckerTest.java	Removed unused import and mock variable
JdbcAdminTestUtils.java	Updated to reference metadata constants from new service classes
MultiStorageAdminTestUtils.java	Updated to reference metadata constants from new service classes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[brfrn169]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the JdbcAdmin class by extracting metadata management logic into new TableMetadataService and NamespaceMetadataService classes. This is a significant improvement in terms of code organization and separation of concerns. The changes are well-executed, and the tests have been updated to match. I have a couple of suggestions for minor improvements related to code duplication and a small inefficiency, which I've detailed in the comments. Overall, this is a solid and beneficial refactoring.

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Torch3333]

LGTM, thank you!

[KodaiD]

LGTM. Thank you!

[komamitsu]

LGTM! 👍

[feeblefakie]

LGTM! Thank you!