From 721c9729492af1d6d0cce34f6a48dda9a9978f03 Mon Sep 17 00:00:00 2001 From: Andres Rios Tascon Date: Mon, 24 Nov 2025 11:22:26 -0500 Subject: [PATCH 1/3] Pin minio version --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 6684b3228..85228389c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -23,7 +23,7 @@ test = [ "deflate", "fsspec-xrootd>=0.5.0", "isal", - "minio", + "minio<=7.2.18", "paramiko", "pytest-rerunfailures", "rangehttpserver", From 4232d78cf739c8a78142d4ae1d304afab4c70bd7 Mon Sep 17 00:00:00 2001 From: Andres Rios Tascon Date: Tue, 25 Nov 2025 10:32:11 -0500 Subject: [PATCH 2/3] Added explicit kwargs --- src/uproot/source/s3.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/uproot/source/s3.py b/src/uproot/source/s3.py index 0539f9384..19a9eb58c 100644 --- a/src/uproot/source/s3.py +++ b/src/uproot/source/s3.py @@ -73,7 +73,7 @@ def __init__( region = parsed_query["region"] client = Minio( - endpoint, + endpoint=endpoint, access_key=access_key, secret_key=secret_key, session_token=session_token, @@ -83,6 +83,8 @@ def __init__( credentials=credentials, ) - url = client.get_presigned_url("GET", bucket_name, object_name) + url = client.get_presigned_url( + method="GET", bucket_name=bucket_name, object_name=object_name + ) super().__init__(url, **options) From 949260cc8aa19283fa6f74f448112d45b2bb1115 Mon Sep 17 00:00:00 2001 From: Andres Rios Tascon Date: Tue, 25 Nov 2025 10:33:29 -0500 Subject: [PATCH 3/3] Unpin minio --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 85228389c..6684b3228 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -23,7 +23,7 @@ test = [ "deflate", "fsspec-xrootd>=0.5.0", "isal", - "minio<=7.2.18", + "minio", "paramiko", "pytest-rerunfailures", "rangehttpserver",