Skip to content

Commit f0e3c99

Browse files
committed
ci: Update codecov, update compilation flags
Swap out Ofast for O3 in compile args Ofast is deprecated, and it defaults to `-O3 -ffast-math`. `ffast-math` does not handle infinities correctly, which lead to failures on all the macos runners and wheel builds. Bump action versions Suppress no array bound warnings on windows Only get test coverage for source files Try skipping py314 free-threaded builds for now
1 parent a005e94 commit f0e3c99

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

.github/workflows/build_and_deploy.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,20 @@ jobs:
2323
]
2424

2525
steps:
26-
- uses: actions/checkout@v4
26+
- uses: actions/checkout@v5
2727

2828
- name: Clone robinhood
2929
run: |
3030
git clone https://github.com/martinus/robin-hood-hashing robinhood
3131
3232
- name: Build wheels
33-
uses: pypa/cibuildwheel@v2.23.3
33+
uses: pypa/cibuildwheel@v3.2.0
3434
env:
35-
CIBW_SKIP: "pp* cp36-* cp37-* *win_arm64 *_i686"
35+
CIBW_SKIP: "*win_arm64 *_i686"
3636
CIBW_BUILD_VERBOSITY: 1
3737
CIBW_TEST_REQUIRES: pytest
3838
CIBW_TEST_COMMAND: "pytest {project}/tests"
39-
CIBW_TEST_SKIP: "*win32 *musllinux*"
39+
CIBW_TEST_SKIP: "*win32 *musllinux* cp314t-*"
4040

4141
- uses: actions/upload-artifact@v4
4242
with:
@@ -47,7 +47,7 @@ jobs:
4747
name: Build source distribution
4848
runs-on: ubuntu-latest
4949
steps:
50-
- uses: actions/checkout@v4
50+
- uses: actions/checkout@v5
5151

5252
- name: Clone robinhood
5353
run: |
@@ -72,7 +72,7 @@ jobs:
7272
id-token: write
7373
if: github.event_name == 'release' && github.event.action == 'published'
7474
steps:
75-
- uses: actions/download-artifact@v4
75+
- uses: actions/download-artifact@v5
7676
with:
7777
# unpacks all CIBW artifacts into dist/
7878
pattern: cibw-*

.github/workflows/python-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ jobs:
1919
runs-on: ${{ matrix.os }}
2020

2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@v5
2323
- name: Set up Python ${{ matrix.python-version }}
24-
uses: actions/setup-python@v5
24+
uses: actions/setup-python@v6
2525
with:
2626
python-version: ${{ matrix.python-version }}
2727
- name: Install dependencies
@@ -38,7 +38,7 @@ jobs:
3838
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
3939
- name: Test with pytest
4040
run: |
41-
pytest --cov-report=xml --cov=./
41+
pytest --cov-report=xml --cov-report=term --cov=src/ripser
4242
- name: Upload coverage results
4343
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
4444
uses: codecov/codecov-action@v5
@@ -57,7 +57,7 @@ jobs:
5757
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
5858

5959
steps:
60-
- uses: actions/checkout@v4
60+
- uses: actions/checkout@v5
6161
- uses: conda-incubator/setup-miniconda@v3
6262
with:
6363
auto-update-conda: true
@@ -82,7 +82,7 @@ jobs:
8282
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
8383

8484
steps:
85-
- uses: actions/checkout@v4
85+
- uses: actions/checkout@v5
8686
- uses: conda-incubator/setup-miniconda@v3
8787
with:
8888
auto-update-conda: true

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def run(self):
4141
build_ext.run(self)
4242

4343

44-
extra_compile_args = ["-Ofast", "-D_hypot=hypot"]
44+
extra_compile_args = ["-O3", "-D_hypot=hypot"]
4545
extra_link_args = []
4646

4747
if platform.system() == "Windows":

0 commit comments

Comments
 (0)