Concurrency issues resulting in TypeError: unsupported operand type(s) for -: 'NoneType' and 'relativedelta'

[andrek-data-axle]

I am assuming its a concurrency issue because the only way I can get it to fail is running multiple calls to dateparser.parse('14 days ago UTC') on separate threads.

  File "/var/app/current/credit/users/services/profile.py", line 67, in add_profile
    date_viewed__gt=dateparser.parse('14 days ago UTC')
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/conf.py", line 85, in wrapper
    return f(*args, **kwargs)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/__init__.py", line 53, in parse
    data = parser.get_date_data(date_string, date_formats)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/date.py", line 418, in get_date_data
    locale, date_string, date_formats, settings=self._settings)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/date.py", line 194, in parse
    return instance._parse()
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/date.py", line 198, in _parse
    date_obj = self._parsers[parser_name]()
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/date.py", line 212, in _try_freshness_parser
    return freshness_date_parser.get_date_data(self._get_translated_date(), self._settings)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/freshness_date_parser.py", line 149, in get_date_data
    date, period = self.parse(date_string, settings)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/freshness_date_parser.py", line 94, in parse
    date, period = self._parse_date(date_string, settings.PREFER_DATES_FROM)
  File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/dateparser/freshness_date_parser.py", line 134, in _parse_date
    date = self.now - td
TypeError: unsupported operand type(s) for -: 'NoneType' and 'relativedelta'

[abkonsta]

I monkey patched in my project and was able to stress-test it with no more concurrency issues in freshness_date_parser
Pull request submitted.

[Gallaecio]

dateparser is not thread-safe.

[abkonsta]

But it can be made to be...

…

On Fri, Oct 30, 2020, 5:17 PM Adrián Chaves ***@***.***> wrote: dateparser is not thread-safe <#441>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#813 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI4UNDFZZ3ZCRRVU6IRAETSNMUOPANCNFSM4STMALVQ> .

[Gallaecio]

Shall we close this and keep just #441 to track work to make it thread-safe?

[abkonsta]

I was going to resubmit my pull request with the recommended edits.

…

On Wed, Nov 4, 2020, 4:47 PM Adrián Chaves ***@***.***> wrote: Shall we close this and keep just #441 <#441> to track work to make it thread-safe? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#813 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI4UNGN3MO5H4NMTF4ZCXDSOHDWZANCNFSM4STMALVQ> .

[noviluni]

Closing as duplicate of #441. I hope this PR: #834 would fix this once and for all :)

Thanks for providing feedback!