-
Notifications
You must be signed in to change notification settings - Fork 485
Fixing #894 and correcting tests #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
5583f3a
fff5112
a77cb4c
3a93e8a
0ea06bc
4e729e8
5773f76
b169301
fba58dd
2aff295
5d8e3d5
c21e428
34f49b9
50c1d30
0563be4
c089907
dbd12ec
4343cd4
2ff140e
14bb443
840e2a3
2f61776
4810bc6
95fbe1d
61bfe13
98b6ba6
da1c1c3
ff1e856
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -86,10 +86,12 @@ def split_if_not_parsed(self, item, original): | |||||||||||||
| possible_splits.extend(self.split_by(item, original, splitter)) | ||||||||||||||
| return possible_splits | ||||||||||||||
|
|
||||||||||||||
| def parse_item(self, parser, item, translated_item, parsed, need_relative_base): | ||||||||||||||
| def parse_item(self, parser, item, translated_item, parsed, need_relative_base, language): | ||||||||||||||
| relative_base = None | ||||||||||||||
| item = item.replace('ngày', '') | ||||||||||||||
| item = item.replace('am', '') | ||||||||||||||
|
|
||||||||||||||
| if language == "de": | ||||||||||||||
gavishpoddar marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
| item = item.replace('am', '') | ||||||||||||||
gavishpoddar marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||
| if language == "de": | |
| item = item.replace('am', '') | |
| if language == "de": | |
| # Replace "am" because "am 8" means "on the 8th" but "8 am" actually | |
| # means "8 am" | |
| item = item.replace('am', '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm... Maybe we can use regex (re.sub) to remove it only when preceding a number? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @noviluni, I have made some can you please check and recommend
Uh oh!
There was an error while loading. Please reload this page.