Implement packaging tests

Author: dkropachev

.github/workflows/build-cpack-packages.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Install tooling
         run: |
           sudo apt-get update
-          sudo apt-get install -y rpm ninja-build
+          sudo apt-get install -y rpm ninja-build pkg-config
 
       - name: Configure
         run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ inputs.build-type }} ${{ inputs.extra-cmake-flags }}
@@ -59,12 +59,61 @@ jobs:
           cpack -G DEB -C ${{ inputs.build-type }}
           cpack -G RPM -C ${{ inputs.build-type }}
 
+      - name: Install driver package (DEB)
+        if: runner.os == 'Linux'
+        run: |
+          set -euo pipefail
+          shopt -s nullglob
+          DRIVER_PACKAGES=(build/*.deb)
+          if [ "${#DRIVER_PACKAGES[@]}" -eq 0 ]; then
+            echo "No driver DEB packages produced"
+            exit 1
+          fi
+          sudo dpkg -i "${DRIVER_PACKAGES[@]}"
+          sudo apt-get install -f -y
+
+      - name: Build smoke-test application package
+        if: runner.os == 'Linux'
+        run: |
+          set -euo pipefail
+          cmake -S packaging/smoke-test-app -B packaging/smoke-test-app/build \
+            -G Ninja -DCMAKE_BUILD_TYPE=${{ inputs.build-type }}
+          cmake --build packaging/smoke-test-app/build --config ${{ inputs.build-type }}
+          (cd packaging/smoke-test-app/build && cpack -G DEB -C ${{ inputs.build-type }})
+          (cd packaging/smoke-test-app/build && cpack -G RPM -C ${{ inputs.build-type }})
+
+      - name: Install smoke-test application package (DEB)
+        if: runner.os == 'Linux'
+        run: |
+          set -euo pipefail
+          shopt -s nullglob
+          APP_PACKAGES=(packaging/smoke-test-app/build/*.deb)
+          if [ "${#APP_PACKAGES[@]}" -eq 0 ]; then
+            echo "No smoke-test DEB packages produced"
+            exit 1
+          fi
+          sudo dpkg -i "${APP_PACKAGES[@]}"
+          sudo apt-get install -f -y
+
+      - name: Run smoke-test application against local Scylla
+        if: runner.os == 'Linux'
+        run: |
+          set -euo pipefail
+          cleanup() {
+            sudo docker compose -f tests/examples_cluster/docker-compose.yml down --remove-orphans
+          }
+          trap cleanup EXIT
+          sudo docker compose -f tests/examples_cluster/docker-compose.yml up -d --wait
+          /usr/bin/scylla-cpp-driver-smoke-test 172.43.0.2
+
       - name: Collect artifacts
         run: |
           set -euo pipefail
           shopt -s nullglob
           mkdir -p artifacts/linux
-          for file in build/*.deb build/*.rpm; do
+          for file in build/*.deb build/*.rpm \
+                      packaging/smoke-test-app/build/*.deb \
+                      packaging/smoke-test-app/build/*.rpm; do
             cp "$file" artifacts/linux/
           done
 
@@ -93,12 +142,63 @@ jobs:
           cpack -G productbuild -C ${{ inputs.build-type }}
           cpack -G DragNDrop -C ${{ inputs.build-type }}
 
+      - name: Install driver package (pkg)
+        if: runner.os == 'macOS'
+        run: |
+          set -euo pipefail
+          shopt -s nullglob
+          packages=(build/*.pkg)
+          if [ "${#packages[@]}" -eq 0 ]; then
+            echo "No driver pkg packages produced"
+            exit 1
+          fi
+          for pkg in "${packages[@]}"; do
+            sudo installer -pkg "$pkg" -target /
+          done
+
+      - name: Build smoke-test application package
+        if: runner.os == 'macOS'
+        run: |
+          set -euo pipefail
+          cmake -S packaging/smoke-test-app -B packaging/smoke-test-app/build \
+            -DCMAKE_BUILD_TYPE=${{ inputs.build-type }}
+          cmake --build packaging/smoke-test-app/build --config ${{ inputs.build-type }}
+          (cd packaging/smoke-test-app/build && cpack -G productbuild -C ${{ inputs.build-type }})
+          (cd packaging/smoke-test-app/build && cpack -G DragNDrop -C ${{ inputs.build-type }})
+
+      - name: Install smoke-test application package (pkg)
+        if: runner.os == 'macOS'
+        run: |
+          set -euo pipefail
+          shopt -s nullglob
+          packages=(packaging/smoke-test-app/build/*.pkg)
+          if [ "${#packages[@]}" -eq 0 ]; then
+            echo "No smoke-test pkg packages produced"
+            exit 1
+          fi
+          for pkg in "${packages[@]}"; do
+            sudo installer -pkg "$pkg" -target /
+          done
+
+      - name: Run smoke-test application against local Scylla
+        if: runner.os == 'macOS'
+        run: |
+          set -euo pipefail
+          cleanup() {
+            docker compose -f tests/examples_cluster/docker-compose.yml down --remove-orphans
+          }
+          trap cleanup EXIT
+          docker compose -f tests/examples_cluster/docker-compose.yml up -d --wait
+          /usr/local/bin/scylla-cpp-driver-smoke-test 172.43.0.2
+
       - name: Collect artifacts
         run: |
           set -euo pipefail
           shopt -s nullglob
           mkdir -p artifacts/macos
-          for file in build/*.pkg build/*.dmg; do
+          for file in build/*.pkg build/*.dmg \
+                      packaging/smoke-test-app/build/*.pkg \
+                      packaging/smoke-test-app/build/*.dmg; do
             cp "$file" artifacts/macos/
           done
 
@@ -142,6 +242,11 @@ jobs:
           "OPENSSL_LIB_DIR=$libPath" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
           "OPENSSL_INCLUDE_DIR=$(Join-Path $opensslRoot 'include')" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
 
+      - name: Install pkg-config
+        shell: pwsh
+        run: |
+          choco install pkgconfiglite --no-progress -y
+
       - name: Configure
         shell: pwsh
         run: |
@@ -156,12 +261,81 @@ jobs:
         working-directory: build
         run: cpack -G WIX -C ${{ inputs.build-type }}
 
+      - name: Install driver package (MSI)
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = 'Stop'
+          $packages = Get-ChildItem build -Filter *.msi
+          if (-not $packages) {
+            throw "No driver MSI packages produced"
+          }
+          foreach ($pkg in $packages) {
+            $process = Start-Process msiexec.exe -ArgumentList "/i `"$($pkg.FullName)`" /qn /norestart" -Wait -PassThru
+            if ($process.ExitCode -ne 0) {
+              throw "Failed to install driver package $($pkg.Name): exit code $($process.ExitCode)"
+            }
+          }
+
+      - name: Build smoke-test application package
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = 'Stop'
+          $env:PKG_CONFIG_PATH = "C:/Program Files/ScyllaDB/Scylla CPP Driver/lib/pkgconfig"
+          cmake -S packaging/smoke-test-app -B packaging/smoke-test-app/build -G "Visual Studio 17 2022" -A x64 -DCMAKE_BUILD_TYPE=${{ inputs.build-type }}
+          cmake --build packaging/smoke-test-app/build --config ${{ inputs.build-type }}
+          Push-Location packaging/smoke-test-app/build
+          cpack -G WIX -C ${{ inputs.build-type }}
+          Pop-Location
+
+      - name: Install smoke-test application package (MSI)
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = 'Stop'
+          $packages = Get-ChildItem packaging/smoke-test-app/build -Filter *.msi
+          if (-not $packages) {
+            throw "No smoke-test MSI packages produced"
+          }
+          foreach ($pkg in $packages) {
+            $process = Start-Process msiexec.exe -ArgumentList "/i `"$($pkg.FullName)`" /qn /norestart" -Wait -PassThru
+            if ($process.ExitCode -ne 0) {
+              throw "Failed to install smoke-test package $($pkg.Name): exit code $($process.ExitCode)"
+            }
+          }
+
+      - name: Run smoke-test application against local Scylla
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = 'Stop'
+          $composeFile = "tests/examples_cluster/docker-compose.yml"
+          function Cleanup {
+            docker compose -f $composeFile down --remove-orphans | Out-Null
+          }
+          try {
+            $dockerService = Get-Service -Name docker -ErrorAction SilentlyContinue
+            if ($dockerService -and $dockerService.Status -ne 'Running') {
+              Start-Service docker
+            }
+            docker compose -f $composeFile up -d --wait
+            $smokePath = "C:\Program Files\ScyllaDB\Scylla CPP Driver Smoke Test\bin\scylla-cpp-driver-smoke-test.exe"
+            if (-not (Test-Path $smokePath)) {
+              throw "Smoke-test binary not found at $smokePath"
+            }
+            & $smokePath 172.43.0.2
+          } finally {
+            Cleanup
+          }
+
       - name: Collect artifacts
         if: inputs.save-artifacts
         shell: pwsh
         run: |
           New-Item -ItemType Directory -Path artifacts\windows -Force | Out-Null
           Get-ChildItem build -Filter *.msi | Copy-Item -Destination artifacts\windows
+          Get-ChildItem packaging/smoke-test-app/build -Filter *.msi | Copy-Item -Destination artifacts\windows
 
       - uses: actions/upload-artifact@v4
         if: inputs.save-artifacts

AGENTS.md

@@ -0,0 +1,26 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+- `src/` holds the C++ wrapper sources; keep headers in `include/` mirrored by module.
+- `scylla-rust-wrapper/` contains the Rust crate exposing the FFI; MSRV is 1.85 (see `Cargo.toml`).
+- Tests live in `tests/src/integration` (GoogleTest harness) and `scylla-rust-wrapper/tests` for Rust. CPack packaging config lives in `CMakeLists.txt`, GitHub workflows under `.github/workflows/`, and reusable examples under `examples/`.
+
+## Build, Test, and Development Commands
+- `mkdir build && cd build && cmake .. && make -j` builds the driver; pass CMake options such as `-DCASS_BUILD_INTEGRATION_TESTS=ON` when needed.
+- `make check` runs clang-format, `cargo check`, `cargo clippy` (with integration flags), and `cargo fmt --check`.
+- `make run-test-unit` executes the Rust unit suite; `make run-test-integration-scylla` spins up a CCM cluster and runs `build/cassandra-integration-tests` against Scylla. Use `DONT_REBUILD_INTEGRATION_BIN=1` to reuse an existing build.
+
+## Coding Style & Naming Conventions
+- C and C++ sources follow `.clang-format` (2-space indent, 100 column limit, no tabs). Keep C API names stable (e.g., `cass_*`) to preserve downstream compatibility.
+- Rust code must satisfy `cargo fmt` and `cargo clippy -- -D warnings -Aclippy::uninlined_format_args`; avoid the disallowed pointer conversions listed in `scylla-rust-wrapper/clippy.toml`.
+- Prefer descriptive snake_case for internal helpers, PascalCase for types, and mirror header/implementation filenames between `include/` and `src/`.
+
+## Testing Guidelines
+- Place new C++ integration cases under `tests/src/integration` and register them with GoogleTest. Update `{SCYLLA,CASSANDRA}_TEST_FILTER` in the `Makefile` when enabling suites.
+- Rust-facing logic should gain coverage via `cargo test`; add integration fixtures under `scylla-rust-wrapper/tests` when exercising FFI.
+- When touching docker-based examples, verify with `make run-examples-scylla`; clean fixtures by rerunning the target to tear down the compose stack.
+
+## Commit & Pull Request Guidelines
+- Follow the existing history style: concise, present-tense summaries with optional area prefixes (`docs:`, `README.md:`). Split unrelated changes into separate commits.
+- Before opening a PR, run `make check` and the relevant test targets, then complete the checklist in `.github/pull_request_template.md`.
+- PR descriptions should detail the rationale, list manual test evidence, and link issues via `Fixes: #123`. Include configuration notes (e.g., CMake flags) or screenshots when behavior changes.