Skip to content

cluster: tracing config options #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
muzarski wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

cluster: tracing config options #199

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ac8dac
CassConsistency: adjust converion to serial variants of Consistency
muzarski Oct 24, 2024
daeba25
cluster: set tracing consistency
muzarski Oct 24, 2024
1a8b778
cluster: set tracing info fetch interval
muzarski Oct 24, 2024
93c68a8
cluster: set tracing info fetch timeout
muzarski Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scylla-rust-wrapper/src/cass_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,8 @@ impl TryFrom<CassConsistency> for Consistency {
CassConsistency::CASS_CONSISTENCY_LOCAL_QUORUM => Ok(Consistency::LocalQuorum),
Copy link
Contributor

@wprzytula wprzytula Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in commit name: CassConsistency: adjust converion to serial variants of Consistency -> conversion

CassConsistency::CASS_CONSISTENCY_EACH_QUORUM => Ok(Consistency::EachQuorum),
CassConsistency::CASS_CONSISTENCY_LOCAL_ONE => Ok(Consistency::LocalOne),
CassConsistency::CASS_CONSISTENCY_LOCAL_SERIAL => Ok(Consistency::LocalSerial),
CassConsistency::CASS_CONSISTENCY_SERIAL => Ok(Consistency::Serial),
Comment on lines +858 to +859
Copy link
Contributor

@wprzytula wprzytula Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug fix! Let's prioritise such things more, instead of packing them into PRs with new features. Bugs should be fixed ASAP!

Copy link
Contributor

@Lorak-mmk Lorak-mmk Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a driver still in alpha packing a bugfix in a small PR like this is imo perfectly acceptable.

_ => Err(()),
}
}
Expand Down