feat(restore_test): add test for changing backup method

This commit adds TestRestoreFullChangingMethodIntegration,
which verifies that changing backup method from rclone to native
and so forth results in a correct restore.
It also removes new task ID generation on every backup/restore run,
as it shouldn't be needed and prevents from verifying retention
policy behavior.

Author: Michal-Leszczynski

pkg/service/restore/helper_integration_test.go

@@ -257,7 +257,6 @@ func defaultTestBackupProperties(loc backupspec.Location, ks string) map[string]
 func (h *testHelper) runBackup(t *testing.T, props map[string]any) string {
 	Printf("Run backup with properties: %v", props)
 	ctx := context.Background()
-	h.srcCluster.TaskID = uuid.NewTime()
 	h.srcCluster.RunID = uuid.NewTime()
 
 	rawProps, err := json.Marshal(props)
@@ -286,7 +285,6 @@ func (h *testHelper) runBackup(t *testing.T, props map[string]any) string {
 func (h *testHelper) runRestore(t *testing.T, props map[string]any) {
 	Printf("Run restore with properties: %v", props)
 	ctx := context.Background()
-	h.dstCluster.TaskID = uuid.NewTime()
 	h.dstCluster.RunID = uuid.NewTime()
 
 	rawProps, err := json.Marshal(props)

pkg/service/restore/restore_integration_test.go

@@ -1454,6 +1454,80 @@ func TestRestoreTablesMethodIntegration(t *testing.T) {
 	}
 }
 
+func TestRestoreFullChangingMethodIntegration(t *testing.T) {
+	h := newTestHelper(t, ManagedClusterHosts(), ManagedSecondClusterHosts())
+	ctx := context.Background()
+
+	ni, err := h.srcCluster.Client.AnyNodeInfo(ctx)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if ok, err := ni.SupportsNativeBackupAPI(); err != nil {
+		t.Fatal(err)
+	} else if !ok {
+		t.Skip("Test assumes native backup api support")
+	}
+
+	Print("Keyspace setup")
+	ksStmt := "CREATE KEYSPACE %q WITH replication = {'class': 'NetworkTopologyStrategy', 'dc1': %d}"
+	ks := randomizedName("changing_method_")
+	ExecStmt(t, h.srcCluster.rootSession, fmt.Sprintf(ksStmt, ks, 2))
+
+	Print("Table setup")
+	tabStmt := "CREATE TABLE %q.%q (id int PRIMARY KEY, data int)"
+	tab := randomizedName("tab_")
+	ExecStmt(t, h.srcCluster.rootSession, fmt.Sprintf(tabStmt, ks, tab))
+
+	Print("Location and permissions setup")
+	loc := testLocation("changing-method", "")
+	S3InitBucket(t, loc.Path)
+	ksFilter := []string{ks}
+	backupProps := defaultTestBackupProperties(loc, ks)
+	// Configure retention policy so that the last backup happens after purge
+	backupProps["retention"] = 3
+	backupProps["retention_days"] = 0
+	backupProps["retention_map"] = backup.RetentionMap{
+		h.srcCluster.TaskID: backup.RetentionPolicy{
+			RetentionDays: 0,
+			Retention:     3,
+		},
+	}
+	grantRestoreSchemaPermissions(t, h.dstCluster.rootSession, h.dstUser)
+	grantRestoreTablesPermissions(t, h.dstCluster.rootSession, ksFilter, h.dstUser)
+
+	type testIter struct {
+		backupMethod backup.Method
+		rowCnt       int
+	}
+	testCases := []testIter{
+		{backupMethod: backup.MethodRclone, rowCnt: 50},
+		{backupMethod: backup.MethodNative, rowCnt: 100},
+		{backupMethod: backup.MethodRclone, rowCnt: 150},
+		{backupMethod: backup.MethodNative, rowCnt: 200},
+		{backupMethod: backup.MethodRclone, rowCnt: 250},
+	}
+	for i, tc := range testCases {
+		t.Log("Fill: ", i)
+		fillTable(t, h.srcCluster.rootSession, tc.rowCnt, ks, tab)
+
+		t.Log("Backup: ", i)
+		backupProps["method"] = tc.backupMethod
+		tag := h.runBackup(t, backupProps)
+
+		t.Log("Restore schema: ", i)
+		ExecStmt(t, h.dstCluster.rootSession, fmt.Sprintf("DROP KEYSPACE IF EXISTS %q", ks))
+		restoreProps := defaultTestProperties(loc, tag, false)
+		h.runRestore(t, restoreProps)
+
+		t.Log("Restore tables: ", i)
+		restoreProps = defaultTestProperties(loc, tag, true)
+		h.runRestore(t, restoreProps)
+
+		t.Log("Validate: ", i)
+		h.validateIdenticalTables(t, []table{{ks: ks, tab: tab}})
+	}
+}
+
 func TestRestoreFullAlternatorIntegration(t *testing.T) {
 	h := newTestHelper(t, ManagedSecondClusterHosts(), ManagedClusterHosts())