Handle colocated table repair error #4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/4565-colocated-table-repair
branch
2 times, most recently
from
c44bde6 to
9f13a09
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
|
@karol-kokoszka @VAveryanov8 this PR is ready for review (but it should probably be merged after required changes land in |
VAveryanov8
approved these changes
Oct 21, 2025
Scylla 2025.4 introduces concept of colocated tablet tables which cannot be repaired directly, but they are repaired when their base table is repaired. Because of that, SM should ignore such error after making sure that the base table is included in repaired units. Fixes #4565
Michal-Leszczynski
force-pushed
the
ml/4565-colocated-table-repair
branch
from
9f13a09 to
1d90153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scylladb/scylladb#26568 has been merged, but is not yet a part of
scylla-nightly:latest(so CI fails).Verified locally that the colocated table repair test passes against
scylla-nightly:2026.1.0-dev-0.20251021.ba692d18058f-x86_64.Scylla 2025.4 introduces concept of colocated tablet tables which cannot be repaired directly, but they are repaired when their base table is repaired. Because of that, SM should ignore such error after making sure that the base table is included in repaired units.
Fixes #4565