From 1dd70702381241de59d8fad40bd1df96750dfcde Mon Sep 17 00:00:00 2001 From: Kieran Date: Thu, 24 Apr 2025 11:09:12 +0100 Subject: [PATCH 1/3] Implicitly marking parameter $runner as nullable is deprecated --- src/Backup/Cli.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Backup/Cli.php b/src/Backup/Cli.php index 62dfb735..18bc8bdb 100644 --- a/src/Backup/Cli.php +++ b/src/Backup/Cli.php @@ -48,7 +48,7 @@ abstract class Cli * @param \SebastianFeldmann\Cli\Command\Runner $runner * @param int|null $time */ - public function __construct(Runner $runner = null, ?int $time = null) + public function __construct(?Runner $runner = null, ?int $time = null) { $this->runner = $runner ? : new Runner\Simple(new Symfony()); $this->time = $time ? : time(); From 276071328d70da8d2623217680dc4363c549514c Mon Sep 17 00:00:00 2001 From: Kieran Date: Wed, 18 Jun 2025 12:47:04 +0100 Subject: [PATCH 2/3] test on php 8.4 --- .github/workflows/integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 21f58f22..c0db46b2 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -12,7 +12,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - php: ['8.0', '8.1', '8.2', '8.3'] + php: ['8.0', '8.1', '8.2', '8.3', '8.4'] steps: - uses: actions/checkout@master From 0100c4b76bac199a58294a824fe8e95b6099ec90 Mon Sep 17 00:00:00 2001 From: Kieran Date: Wed, 18 Jun 2025 12:48:32 +0100 Subject: [PATCH 3/3] Update Abstraction.php --- src/Backup/Compressor/Abstraction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Backup/Compressor/Abstraction.php b/src/Backup/Compressor/Abstraction.php index 12baf476..6cdb5c2b 100644 --- a/src/Backup/Compressor/Abstraction.php +++ b/src/Backup/Compressor/Abstraction.php @@ -42,7 +42,7 @@ abstract class Abstraction extends Cli implements Compressible * @param \SebastianFeldmann\Cli\Command\Runner $runner * @throws \phpbu\App\Exception */ - public function __construct($path, $pathToCommand = '', Runner $runner = null) + public function __construct($path, $pathToCommand = '', ?Runner $runner = null) { if (empty($path)) { throw new Exception('no path to compress set');