removed RenderPipeline.RenderSceneView()

Author: lou-andreev

Assets/ScriptableRenderLoop/HDRenderLoop/HDRenderLoop.cs

@@ -537,15 +537,6 @@ void RenderDistortion(CullResults cullResults, Camera camera, RenderLoop renderL
             }
         }
 
-#if UNITY_EDITOR
-        public override void RenderSceneView(Camera camera, RenderLoop renderLoop)
-        {
-            base.RenderSceneView(camera, renderLoop);
-            renderLoop.PrepareForEditorRendering(camera, m_CameraDepthBufferRT);
-            renderLoop.Submit();
-        }
-#endif
-
         void FinalPass(RenderLoop renderLoop)
         {
             using (new Utilities.ProfilingSample("Final Pass", renderLoop))
@@ -720,6 +711,15 @@ public override void Render(Camera[] cameras, RenderLoop renderLoop)
                     FinalPass(renderLoop);
                 }
 
+                // bind depth surface for editor grid/gizmo/selection rendering
+                if (camera.cameraType == CameraType.SceneView)
+                {
+                    var cmd = new CommandBuffer();
+                    cmd.SetRenderTarget(BuiltinRenderTextureType.CameraTarget, m_CameraDepthBufferRT);
+                    renderLoop.ExecuteCommandBuffer(cmd);
+                    cmd.Dispose();
+                }
+
                 renderLoop.Submit();
             }
 

Assets/ScriptableRenderLoop/fptl/FptlLighting.cs

@@ -266,7 +266,7 @@ static void SetupGBuffer(int width, int height, CommandBuffer cmd)
             cmd.GetTemporaryRT(s_GBufferZ, width, height, 24, FilterMode.Point, RenderTextureFormat.Depth);
             cmd.GetTemporaryRT(s_CameraDepthTexture, width, height, 24, FilterMode.Point, RenderTextureFormat.Depth);
             cmd.GetTemporaryRT(s_CameraTarget, width, height, 0, FilterMode.Point, formatHDR, RenderTextureReadWrite.Default, 1, true); // rtv/uav
-
+            
             var colorMRTs = new RenderTargetIdentifier[4] { s_GBufferAlbedo, s_GBufferSpecRough, s_GBufferNormal, s_GBufferEmission };
             cmd.SetRenderTarget(colorMRTs, new RenderTargetIdentifier(s_GBufferZ));
             cmd.ClearRenderTarget(true, true, new Color(0, 0, 0, 0));
@@ -347,7 +347,7 @@ bool usingFptl
                 return !disableFptl;
             }
         }
-
+        
         static void CopyDepthAfterGBuffer(RenderLoop loop)
         {
             var cmd = new CommandBuffer { name = "Copy depth" };
@@ -470,8 +470,8 @@ void DoTiledDeferredLighting(Camera camera, RenderLoop loop, int numLights, int
             }
             else
             {
-                cmd.Blit(0, s_CameraTarget, m_DeferredMaterial, 0);
-                cmd.Blit(0, s_CameraTarget, m_DeferredReflectionMaterial, 0);
+                cmd.Blit(BuiltinRenderTextureType.CameraTarget, s_CameraTarget, m_DeferredMaterial, 0);
+                cmd.Blit(BuiltinRenderTextureType.CameraTarget, s_CameraTarget, m_DeferredReflectionMaterial, 0);
             }
 
 
@@ -974,15 +974,6 @@ int GenerateSourceLightBuffers(Camera camera, CullResults inputs)
             return numLightsOut + numProbesOut;
         }
 
-#if UNITY_EDITOR
-        public override void RenderSceneView(Camera camera, RenderLoop renderLoop)
-        {
-            base.RenderSceneView(camera, renderLoop);
-            renderLoop.PrepareForEditorRendering(camera, new RenderTargetIdentifier(s_CameraDepthTexture));
-            renderLoop.Submit();
-        }
-#endif
-
         public override void Render(Camera[] cameras, RenderLoop renderLoop)
         {
             foreach (var camera in cameras)
@@ -1065,9 +1056,20 @@ void ExecuteRenderLoop(Camera camera, CullResults cullResults, RenderLoop loop)
 
             // debug views.
             if (enableDrawLightBoundsDebug) DrawLightBoundsDebug(loop, cullResults.visibleLights.Length);
-
+            
             // present frame buffer.
             FinalPass(loop);
+
+            // bind depth surface for editor grid/gizmo/selection rendering
+            if (camera.cameraType == CameraType.SceneView)
+            {
+                var cmd = new CommandBuffer();
+                cmd.SetRenderTarget(BuiltinRenderTextureType.CameraTarget, new RenderTargetIdentifier(s_CameraDepthTexture));
+                loop.ExecuteCommandBuffer(cmd);
+                cmd.Dispose();
+            }
+            loop.Submit();
+
         }
 
         void DrawLightBoundsDebug(RenderLoop loop, int numLights)