Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Sep 30, 2025

TCP transport is good enough to use in tests. Using the TCP transport in all tests significantly improves the transport logic coverage.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 30, 2025, 12:43 PM

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.96%. Comparing base (456f01e) to head (c27efde).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/p2p/conn/connection.go 0.00% 2 Missing and 1 partial ⚠️
internal/p2p/transport_mconn.go 95.45% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   57.09%   56.96%   -0.13%     
==========================================
  Files         255      254       -1     
  Lines       33956    33815     -141     
==========================================
- Hits        19386    19264     -122     
+ Misses      13029    13008      -21     
- Partials     1541     1543       +2     
Files with missing lines Coverage Δ
internal/blocksync/pool.go 80.00% <ø> (-0.86%) ⬇️
internal/p2p/router.go 77.48% <ø> (-1.95%) ⬇️
internal/p2p/transport_mconn.go 84.18% <95.45%> (+2.16%) ⬆️
internal/p2p/conn/connection.go 79.54% <0.00%> (-0.23%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pompon0 pompon0 merged commit c6c5a8f into main Oct 1, 2025
27 checks passed
@pompon0 pompon0 deleted the gprusak-nomem4 branch October 1, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants