Skip to content

Conversation

@Dimi1010
Copy link
Collaborator

Split of #1507.

This PR adds user defined literals for MacAddress, IPv4Address and IPv6Address in the form of _mac, _ipv4, _ipv6 to allow quick construction. It also fixes the const correctness of MacAddress static values.

@Dimi1010 Dimi1010 marked this pull request as ready for review October 20, 2025 11:44
@Dimi1010 Dimi1010 requested a review from seladb as a code owner October 20, 2025 11:44
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (0ae5389) to head (300ca2b).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1999      +/-   ##
==========================================
- Coverage   83.41%   83.41%   -0.01%     
==========================================
  Files         311      311              
  Lines       55027    55023       -4     
  Branches    11777    12114     +337     
==========================================
- Hits        45900    45896       -4     
- Misses       7869     8234     +365     
+ Partials     1258      893     -365     
Flag Coverage Δ
alpine320 75.89% <ø> (ø)
fedora42 75.81% <ø> (-0.02%) ⬇️
macos-14 81.50% <100.00%> (ø)
macos-15 81.51% <100.00%> (ø)
mingw32 70.55% <ø> (-0.02%) ⬇️
mingw64 70.53% <ø> (+0.11%) ⬆️
npcap ?
rhel94 75.83% <ø> (ø)
ubuntu2004 60.13% <ø> (-0.03%) ⬇️
ubuntu2004-zstd 60.25% <ø> (+<0.01%) ⬆️
ubuntu2204 75.77% <ø> (-0.03%) ⬇️
ubuntu2204-icpx 60.55% <ø> (ø)
ubuntu2404 75.88% <ø> (-0.01%) ⬇️
ubuntu2404-arm64 75.54% <ø> (-0.03%) ⬇️
unittest 83.41% <100.00%> (-0.01%) ⬇️
windows-2022 85.42% <100.00%> (+0.16%) ⬆️
windows-2025 85.45% <100.00%> (+0.11%) ⬆️
winpcap 85.45% <100.00%> (-0.09%) ⬇️
xdp 53.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 merged commit a01e705 into seladb:dev Oct 21, 2025
40 checks passed
@Dimi1010 Dimi1010 deleted the feature/ip-mac-literals branch October 21, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants