Skip to content

Commit 74da7cc

Browse files
authored
fix: precise object dependency in effect hook (#831)
Put more precise `queries(: object)` deps to effect hook to prevent unnecessary re-rendering from Channel module.
1 parent 172c3c3 commit 74da7cc

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/modules/ChannelList/context/ChannelListProvider.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,11 @@ const ChannelListProvider: React.FC<ChannelListProviderProps> = (props: ChannelL
221221
sdk?.groupChannel?.removeGroupChannelHandler(sdkChannelHandlerId);
222222
}
223223
};
224-
}, [sdkIntialized, userFilledChannelListQuery, sortChannelList]);
224+
}, [
225+
sdkIntialized,
226+
sortChannelList,
227+
Object.entries(userFilledChannelListQuery ?? {}).map(([key, value]) => key + value).join(),
228+
]);
225229

226230
useEffect(() => {
227231
let typingHandlerId = '';

0 commit comments

Comments
 (0)