Fix: Suppress NO ACK error(#119)

Call markAsRead inside try/catch block
This error occurs in codesandbox
Especially when multiple users are running same sandbox
Error is command no ACK error that comes from markAsRead called in quick succession
This is a stop gap solution
Need to find proper fix.

Fixes: sendbird.atlassian.net/browse/UIKIT-1619

Co-authored-by: Sravan S <sravan@sendbird.com>

Author: sravan-s

src/smart-components/Conversation/hooks/useGetChannel.js

@@ -20,7 +20,11 @@ function useSetChannel({ channelUrl, sdkInit }, {
 
           logger.info('Channel: Mark as read', groupChannel);
           // this order is important - this mark as read should update the event handler up above
-          groupChannel.markAsRead();
+          try {
+            groupChannel.markAsRead();
+          } catch {
+            //
+          }
         })
         .catch((e) => {
           logger.warning('Channel | useSetChannel fetch channel failed', { channelUrl, e });

src/smart-components/Conversation/hooks/useHandleChannelEvents.js

@@ -47,7 +47,11 @@ function useHandleChannelEvents({ currentGroupChannel, sdkInit, hasMoreToBottom
           if (scrollToEnd) {
             try {
               setTimeout(() => {
-                currentGroupChannel.markAsRead();
+                try {
+                  currentGroupChannel.markAsRead();
+                } catch {
+                  //
+                }
                 scrollIntoLast();
               });
             } catch (error) {

src/smart-components/Conversation/hooks/useHandleReconnect.ts

@@ -90,7 +90,11 @@ function useHandleReconnect(
                 logger.error('Channel: Fetching messages failed', error);
               })
               .finally(() => {
-                currentGroupChannel.markAsRead?.();
+                try {
+                  currentGroupChannel.markAsRead?.();
+                } catch {
+                  //
+                }
               });
           });
       }

src/smart-components/Conversation/hooks/useInitialMessagesFetch.js

@@ -119,7 +119,11 @@ function useInitialMessagesFetch({
             if (!intialTimeStamp) {
               setTimeout(() => utils.scrollIntoLast());
             }
-            currentGroupChannel.markAsRead();
+            try {
+              currentGroupChannel.markAsRead();
+            } catch {
+              //
+            }
           });
       } else {
         currentGroupChannel.getMessagesByTimestamp(
@@ -160,7 +164,11 @@ function useInitialMessagesFetch({
             if (!intialTimeStamp) {
               setTimeout(() => utils.scrollIntoLast());
             }
-            currentGroupChannel.markAsRead();
+            try {
+              currentGroupChannel.markAsRead();
+            } catch {
+              //
+            }
           });
       }
     }

src/smart-components/Conversation/hooks/useScrollCallback.js

@@ -70,7 +70,11 @@ function useScrollCallback({
         cb([null, error]);
       })
       .finally(() => {
-        currentGroupChannel.markAsRead();
+        try {
+          currentGroupChannel.markAsRead();
+        } catch {
+          //
+        }
       });
   }, [currentGroupChannel, lastMessageTimeStamp, replyType]);
 }

src/smart-components/Conversation/hooks/useScrollDownCallback.js

@@ -73,7 +73,11 @@ function useScrollDownCallback({
         cb([null, error]);
       })
       .finally(() => {
-        currentGroupChannel.markAsRead();
+        try {
+          currentGroupChannel.markAsRead();
+        } catch {
+          //
+        }
       });
   }, [currentGroupChannel, latestFetchedMessageTimeStamp, hasMoreToBottom, replyType]);
 }

src/smart-components/Conversation/index.jsx

@@ -337,7 +337,11 @@ export const ConversationPanel = (props) => {
                 utils.scrollIntoLast();
                 // there is no scroll
                 if (scrollRef.current.scrollTop === 0) {
-                  currentGroupChannel.markAsRead();
+                  try {
+                    currentGroupChannel.markAsRead();
+                  } catch {
+                    //
+                  }
                   messagesDispatcher({
                     type: messageActionTypes.MARK_AS_READ,
                   });