Make rubocop happy

Author: yakatz

.rubocop.yml

@@ -1,4 +1,5 @@
 AllCops:
+  NewCops: enable
   Exclude:
     - '**/*.erb'
     - 'vendor/**/*'
@@ -18,15 +19,15 @@ Style/SymbolArray:
 Style/WordArray:
   Enabled: false
 
+# There is no real reason to check for line length
+Layout/LineLength:
+  Enabled: false
+
 # This isn't really necessary as they limit us in how
 # long text can be when describing a test
 Metrics/BlockLength:
   Enabled: false
 
-# There is no real reason to check for line length
-Metrics/LineLength:
-  Enabled: false
-
 # Disable MixinUsage
 Style/MixinUsage:
   Enabled: false
@@ -35,4 +36,4 @@ Style/FrozenStringLiteralComment:
   Enabled: false
 
 Style/Documentation:
-  Enabled: false
+  Enabled: false

.ruby-version

@@ -1 +1 @@
-2.3.0
+2.5.0

Gemfile

@@ -3,8 +3,8 @@ source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 puppetversion = ENV.key?('PUPPET_VERSION') ? ENV['PUPPET_VERSION'] : ['>= 3.3', '< 6']
 gem 'facter', '<= 2.4.6', '>= 1.7.0'
 gem 'puppet', puppetversion
-gem 'puppet-lint', '>= 1.0.0'
 gem 'puppetlabs_spec_helper', '>= 1.0.0'
+gem 'puppet-lint', '>= 1.0.0'
 gem 'rspec-puppet', '<= 2.5.0'
 gem 'rspec-puppet-facts', '< 1.8.0'
 gem 'safe_yaml', '~> 1.0.4'

spec/classes/csf_docker_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require_relative '../facts.rb'
+require_relative '../facts'
 
 describe 'csf::docker' do
   context 'supported operating systems' do

spec/classes/csf_init_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require_relative '../facts.rb'
+require_relative '../facts'
 
 describe 'csf' do
   context 'supported operating systems' do

spec/classes/csf_install_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require_relative '../facts.rb'
+require_relative '../facts'
 
 describe 'csf::install' do
   context 'supported operating systems' do

spec/defines/csf_config_spec.rb

@@ -17,7 +17,7 @@
 
         context 'csf::config without parameters' do
           it 'fails' do
-            expect { subject.call } .to raise_error(/Please set a value for/)
+            expect { subject.call }.to raise_error(/Please set a value for/)
           end
         end
 

spec/defines/csf_global_spec.rb

@@ -39,7 +39,7 @@
           end
 
           it 'fails' do
-            expect { subject.call } .to raise_error(/unknown value wrong/)
+            expect { subject.call }.to raise_error(/unknown value wrong/)
           end
         end
       end