Allow override of LokiJsonTextFormatter.Format ?

[tisonv]

Hi !

You can inherit from LokiJsonTextFormatter and override pretty much everything but the Format function can not.
Is there a technical reason ?

In one of my project I only need very few of the available logEvent.Properties but couldn't add a whitelist to filter them.
I ended using a custom internal class based on LokiJsonTextFormatter but I don't like it since I have to track any changes on the source file.

I didn't notice any problem in Loki / Grafana without all my filtered properties.

Thank you !

[mishamyte]

Hi!

It was done historically, prob. Cause it's the only method from the Serilog's ITextFormatter.
It was not a case for a lot of people, but they usually implemented it, when needed a lot of customizations

[mishamyte]

Hello @tisonv!

Added virtual modifier. Already in v8.2.0-beta.0

[tisonv]

Thank you !
May I suggest updating private readonly JsonValueFormatter _valueFormatter; to protected readonly JsonValueFormatter _valueFormatter; ?

[mishamyte]

Oh, damn, missed that. Thank you, will update

[mishamyte]

Added in v8.2.0-beta.1