Skip to content

Add PassthroughBehavior and ContentHandling configuration options for SQS #211

@haykgh

Description

@haykgh

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch serverless-apigateway-service-proxy@2.2.1 for the project I'm working on.

For SQS service, PassthroughBehavior option has 'NEVER' hardcoded value and ContentHandling option ignored. This patch aimed to fix this gap. Please add it to next release.

Here is the diff that solved my problem:

diff --git a/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js b/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
index c9d0cc8..9c556b3 100644
--- a/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
+++ b/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
@@ -75,7 +75,16 @@ module.exports = {
       )
       integration.RequestTemplates = { 'application/json': '{statusCode:200}' }
     } else {
-      integration.PassthroughBehavior = 'NEVER'
+      if ('passThrough' in http.request) {
+        integration.PassthroughBehavior = http.request.passThrough
+      } else {
+        integration.PassthroughBehavior = 'NEVER'
+      }
+
+      if ('contentHandling' in http.request) {
+        integration.ContentHandling = http.request.contentHandling
+      }
+
       integration.RequestParameters = _.merge(
         {
           'integration.request.header.Content-Type': "'application/x-www-form-urlencoded'"

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions