Skip to content

Commit cd662bb

Browse files
committed
chore: don't try to upload release metadata for qa build
1 parent 8e19e96 commit cd662bb

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

.github/workflows/build-binaries.yml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,22 +93,27 @@ jobs:
9393
electron_target: deb
9494
cache_suffix: linux-deb
9595
is_qa: false
96+
generate_release_metadata: true
9697
- identifier: rpm
9798
electron_target: rpm
9899
cache_suffix: linux-rpm
99100
is_qa: false
100-
- identifier: freebsd
101-
electron_target: freebsd
102-
cache_suffix: linux-freebsd
103-
is_qa: false
101+
generate_release_metadata: true
104102
- identifier: AppImage
105103
electron_target: AppImage
106104
cache_suffix: linux-AppImage
107105
is_qa: false
106+
generate_release_metadata: true
107+
- identifier: freebsd
108+
electron_target: freebsd
109+
cache_suffix: linux-freebsd
110+
is_qa: false
111+
generate_release_metadata: false
108112
- identifier: deb-qa
109113
electron_target: deb
110114
cache_suffix: linux-deb
111115
is_qa: true
116+
generate_release_metadata: false
112117
name: '${{ matrix.identifier }}'
113118

114119
env:
@@ -164,15 +169,15 @@ jobs:
164169
# only run this on "push" to "master" or alpha releases
165170
# Note: The jobs are overwriting each other's latest-linux.yml.
166171
# So, we upload all of them as artifacts, and then merge them (see `post_build_linux`)
167-
# note: freebsd does not generate a latest-linux.yml file so we exclude it
168-
if: ${{ needs.create_draft_release_if_needed.outputs.version_tag != '' && matrix.identifier != 'freebsd' }}
172+
# note: freebsd does not generate a latest-linux.yml file so we exclude it, same for the deb-qa build
173+
if: ${{ needs.create_draft_release_if_needed.outputs.version_tag != '' && matrix.generate_release_metadata == true }}
169174
shell: bash
170175
run: |
171176
mv dist/latest-linux.yml dist/latest-linux-${{ matrix.electron_target }}-${{ github.sha }}.yml
172177
173178
- name: Upload release metadata
174179
# only run this on "push" to "master" or alpha releases
175-
if: ${{ needs.create_draft_release_if_needed.outputs.version_tag != '' && matrix.identifier != 'freebsd' }}
180+
if: ${{ needs.create_draft_release_if_needed.outputs.version_tag != '' && matrix.generate_release_metadata == true }}
176181
uses: actions/upload-artifact@v4
177182
with:
178183
name: latest-linux-${{ matrix.electron_target }}-${{ github.sha }}.yml

0 commit comments

Comments
 (0)