Commit 6db68c5
Fix CodeRabbit review issues: invalid config, version consistency, missing require
Addresses 3 critical issues identified in PR #1896 review:
1. Remove invalid javascript_transpiler configuration
- Shakapacker 9.3.0 does not support a top-level javascript_transpiler key
- Removed lines 39-42 from shakapacker.yml template
- Transpiler selection is configured via webpack config and installed loaders
2. Update Pro package.json files to Shakapacker 9.3.0
- Updated react_on_rails_pro/spec/dummy/package.json (8.0.0 → 9.3.0)
- Updated react_on_rails_pro/spec/execjs-compatible-dummy/package.json (8.0.0 → 9.3.0)
- Added swc-loader and @swc/core dependencies to both files
- Ensures version consistency across the codebase
3. Fix missing GeneratorMessages require in generator_helper.rb
- Added require_relative "generator_messages" to prevent NameError
- Issue occurred when detect_package_manager_and_exact_flag found multiple lock files
- Now consistent with other generator files (base_generator.rb, install_generator.rb)
All RuboCop checks pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent a5b19dd commit 6db68c5
File tree
4 files changed
+7
-7
lines changed- lib/generators/react_on_rails
- templates/base/base/config
- react_on_rails_pro/spec
- dummy
- execjs-compatible-dummy
4 files changed
+7
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 39 | | |
45 | 40 | | |
46 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
0 commit comments