Fix: cargo clippy --fix (11 to 5)

Author: t-koba

src/core/builtins/type_.rs

@@ -36,7 +36,7 @@ fn type_no_opt_sub(core: &mut ShellCore, com: &String) -> i32 {
     }
 
     let s = format!("{}: not found", &com);
-    return super::error_exit(1, "type", &s, core);
+    super::error_exit(1, "type", &s, core)
 }
 
 fn type_no_opt(core: &mut ShellCore, args: &[String]) -> i32 {
@@ -117,7 +117,7 @@ fn type_p_sub(core: &mut ShellCore, com: &String) -> i32 {
         return 0;
     }
 
-    if let Ok(path) = core.db.get_elem("BASH_CMDS", &com) {
+    if let Ok(path) = core.db.get_elem("BASH_CMDS", com) {
         if !path.is_empty() {
             println!("{}", &path);
             return 0;

src/elements/command/simple.rs

@@ -197,7 +197,7 @@ impl SimpleCommand {
     fn set_environment_variables(&mut self, core: &mut ShellCore) -> Result<(), ExecError> {
         let layer = core.db.get_layer_num() - 1;
         for (k, v) in &mut core.db.params[layer] {
-            env::set_var(&k, v.get_as_single().unwrap_or("".to_string()));
+            env::set_var(k, v.get_as_single().unwrap_or("".to_string()));
         }
         Ok(())
     }

src/elements/substitution/value.rs

@@ -169,7 +169,7 @@ impl Value {
                 }
                 let txt = "'".to_owned() + &a.text + "'";
                 let mut w = Word::from(txt.as_str());
-                return self.reparse_word(&mut w, core);
+                self.reparse_word(&mut w, core)
             }
             ParsedDataType::None => Ok(()),
         }

src/utils/arg.rs

@@ -63,7 +63,7 @@ pub fn dissolve_option(opt: &str) -> Vec<String> {
     if opt.starts_with("--") {
         vec![opt.to_string()]
     } else if let Some(stripped) = opt.strip_prefix('-') {
-        if stripped == "" {
+        if stripped.is_empty() {
             return vec!["-".to_string()];
         }
 
@@ -72,7 +72,7 @@ pub fn dissolve_option(opt: &str) -> Vec<String> {
             .map(|c| ("-".to_owned() + &c.to_string()).to_string())
             .collect()
     } else if let Some(stripped) = opt.strip_prefix('+') {
-        if stripped == "" {
+        if stripped.is_empty() {
             return vec!["+".to_string()];
         }