Merge pull request #98 from pzuraq/only-move-when-not-static

Only move tethered element if its offset parent is not the body

Author: zackbloom

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "tether",
-  "version": "1.0.3",
+  "version": "1.1.0",
   "homepage": "http://github.hubspot.com/tether",
   "authors": [
     "Zack Bloom <zackbloom@gmail.com>",

component.json

@@ -1,7 +1,7 @@
 {
   "name": "tether",
   "repo": "HubSpot/tether",
-  "version": "1.0.3",
+  "version": "1.1.0",
   "description": "A client-side library to make absolutely positioned elements attach to elements in the page efficiently.",
   "authors": [
     "Zack Bloom <zackbloom@gmail.com>",

dist/js/tether.js

@@ -1,4 +1,4 @@
-/*! tether 1.0.3 */
+/*! tether 1.1.0 */
 
 (function(root, factory) {
   if (typeof define === 'function' && define.amd) {
@@ -182,7 +182,7 @@ function getScrollBarSize() {
 }
 
 function extend() {
-  var out = arguments[0] === undefined ? {} : arguments[0];
+  var out = arguments.length <= 0 || arguments[0] === undefined ? {} : arguments[0];
 
   var args = [];
 
@@ -285,7 +285,7 @@ var Evented = (function () {
   _createClass(Evented, [{
     key: 'on',
     value: function on(event, handler, ctx) {
-      var once = arguments[3] === undefined ? false : arguments[3];
+      var once = arguments.length <= 3 || arguments[3] === undefined ? false : arguments[3];
 
       if (typeof this.bindings === 'undefined') {
         this.bindings = {};
@@ -397,7 +397,7 @@ var flush = _TetherBase$Utils.flush;
 var getScrollBarSize = _TetherBase$Utils.getScrollBarSize;
 
 function within(a, b) {
-  var diff = arguments[2] === undefined ? 1 : arguments[2];
+  var diff = arguments.length <= 2 || arguments[2] === undefined ? 1 : arguments[2];
 
   return a + diff >= b && b >= a - diff;
 }
@@ -590,7 +590,7 @@ var TetherClass = (function () {
   _createClass(TetherClass, [{
     key: 'getClass',
     value: function getClass() {
-      var key = arguments[0] === undefined ? '' : arguments[0];
+      var key = arguments.length <= 0 || arguments[0] === undefined ? '' : arguments[0];
       var classes = this.options.classes;
 
       if (typeof classes !== 'undefined' && classes[key]) {
@@ -606,7 +606,7 @@ var TetherClass = (function () {
     value: function setOptions(options) {
       var _this2 = this;
 
-      var pos = arguments[1] === undefined ? true : arguments[1];
+      var pos = arguments.length <= 1 || arguments[1] === undefined ? true : arguments[1];
 
       var defaults = {
         offset: '0 0',
@@ -788,7 +788,7 @@ var TetherClass = (function () {
   }, {
     key: 'enable',
     value: function enable() {
-      var pos = arguments[0] === undefined ? true : arguments[0];
+      var pos = arguments.length <= 0 || arguments[0] === undefined ? true : arguments[0];
 
       if (!(this.options.addTargetClasses === false)) {
         addClass(this.target, this.getClass('enabled'));
@@ -887,7 +887,7 @@ var TetherClass = (function () {
     value: function position() {
       var _this5 = this;
 
-      var flushChanges = arguments[0] === undefined ? true : arguments[0];
+      var flushChanges = arguments.length <= 0 || arguments[0] === undefined ? true : arguments[0];
 
       // flushChanges commits the changes immediately, leave true unless you are positioning multiple
       // tethers (in which case call Tether.Utils.flush yourself when you're done)
@@ -1165,9 +1165,22 @@ var TetherClass = (function () {
         transcribe({ top: true, left: true }, pos.page);
       }
 
-      if (!moved && this.element.parentNode.tagName !== 'BODY') {
-        this.element.parentNode.removeChild(this.element);
-        document.body.appendChild(this.element);
+      if (!moved) {
+        var offsetParentIsBody = true;
+        var currentNode = this.element.parentNode;
+        while (currentNode && currentNode.tagName !== 'BODY') {
+          if (getComputedStyle(currentNode).position !== 'static') {
+            offsetParentIsBody = false;
+            break;
+          }
+
+          currentNode = currentNode.parentNode;
+        }
+
+        if (!offsetParentIsBody) {
+          this.element.parentNode.removeChild(this.element);
+          document.body.appendChild(this.element);
+        }
       }
 
       // Any css change will trigger a repaint, so let's avoid one if nothing changed

dist/js/tether.min.js

@@ -1,6 +1,6 @@
 {
   "name": "tether",
-  "version": "1.0.3",
+  "version": "1.1.0",
   "description": "A client-side library to make absolutely positioned elements attach to elements in the page efficiently.",
   "authors": [
     "Zack Bloom <zackbloom@gmail.com>",

package.json

@@ -730,9 +730,22 @@ class TetherClass {
       transcribe({top: true, left: true}, pos.page);
     }
 
-    if(!moved && this.element.parentNode.tagName !== 'BODY') {
-      this.element.parentNode.removeChild(this.element);
-      document.body.appendChild(this.element);
+    if (!moved) {
+      let offsetParentIsBody = true;
+      let currentNode = this.element.parentNode;
+      while (currentNode && currentNode.tagName !== 'BODY') {
+        if (getComputedStyle(currentNode).position !== 'static') {
+          offsetParentIsBody = false;
+          break;
+        }
+
+        currentNode = currentNode.parentNode;
+      }
+
+      if (!offsetParentIsBody) {
+        this.element.parentNode.removeChild(this.element);
+        document.body.appendChild(this.element);
+      }
     }
 
     // Any css change will trigger a repaint, so let's avoid one if nothing changed