Skip to content

Commit e4bd6eb

Browse files
authored
fix: Trigger workflow 4 before closing PR (#5)
1 parent 181df2e commit e4bd6eb

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

.github/steps/4-copilot-on-github.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ Now, let's see how Copilot can help us finish up with during our pull request.
2020

2121
1. Below the pull request description, press the green **Create pull request** one more time.
2222

23-
1. Wait a moment Copilot to comment on your pull request!
23+
1. Wait a moment for Copilot to comment on your pull request!
2424

2525
- Notice the log entry indicating a Copilot review was requested.
2626

27-
1. At the bottom, press the green **Merge pull request** button.
27+
1. Back on the exercise issue, wait a moment for Mona to check your work, provide feedback, and post a final review of this lesson!
2828

29-
1. Wait a moment for Mona to check your work, provide feedback, and post a final review of this lesson! Nice work you are done! :tada:
29+
1. At the bottom, press the green **Merge pull request** button. Nice work! You are all done! :tada:

.github/workflows/4-copilot-on-github.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ on:
44
pull_request:
55
branches:
66
- main
7-
types:
8-
- closed
7+
types: [edited]
8+
pull_request_review:
9+
types: [submitted]
910

1011
permissions:
1112
contents: write
@@ -20,8 +21,7 @@ env:
2021
jobs:
2122
find_exercise:
2223
if: |
23-
!github.event.repository.is_template &&
24-
github.event.pull_request.merged
24+
!github.event.repository.is_template
2525
name: Find exercise by issue title
2626
runs-on: ubuntu-latest
2727

@@ -159,8 +159,7 @@ jobs:
159159
- name: Update comment - step finished - final review next
160160
run: |
161161
gh issue comment "$ISSUE_URL" \
162-
--body-file skills-response-templates/step-feedback/lesson-review.md \
163-
--edit-last
162+
--body-file skills-response-templates/step-feedback/lesson-review.md
164163
env:
165164
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
166165

0 commit comments

Comments
 (0)