Standardize the module structure. Make the list of requirements more complete. #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do all of this just to get the tests.sh command in the readme to run, so this PR is probably necessary for maintenance. Let me know if you have any comments or questions.
The specific older versions of pytorch and torchvision in my new requirements.txt are probably fine since:
Other changes:
Alternative PR (not initiated):
If you like pgd (I'm not familiar with it) as shown in this other fork: hyunobae@b79afe9 then I have a separate branch for that you can pull instead, so let me know or go ahead and start a new PR with my pgd-and-new-sckitit-image branch instead: https://github.com/poikilos/TecoGAN-PyTorch/tree/pgd-and-new-scikit-image