Add injection to python rest api (#1508)

* Added support in the restAPI for injections - including creation, deletion, list
* Fixed allinone

Author: ofirZelig

cmd/allinone/allinone.go

@@ -132,9 +132,9 @@ var AllInOneCmd = &cobra.Command{
 			os.Exit(1)
 		}
 
-		os.Setenv("SKYDIVE_ANALYZERS", config.GetString("analyzer.listen"))
+		os.Setenv("SKYDIVE_ANALYZERS", fmt.Sprintf("%s:%d", addr, svcAddr.Port))
 		os.Setenv("SKYDIVE_LOGGING_FILE_PATH", logFile+"-agent"+extension)
-
+		
 		agentAttr := &os.ProcAttr{
 			Files: []*os.File{os.Stdin, os.Stdout, os.Stderr},
 			Env:   os.Environ(),

contrib/python/api/skydive/packet_injector.py

@@ -0,0 +1,104 @@
+#
+# Copyright (C) 2019 Red Hat, Inc.
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+
+class PacketInjection(object):
+    """
+        Definition of a Skydive packet injection.
+    """
+
+    def __init__(self, uuid="", src="", dst="", srcip="", dstip="", srcmac="",
+                 dstmac="", srcport="", dstport="", type="", payload="",
+                 trackingid="", icmpid="", count="", interval="",
+                 increment="", starttime=""):
+        self.uuid = uuid
+        self.src = src
+        self.dst = dst
+        self.srcip = srcip
+        self.dstip = dstip
+        self.srcmac = srcmac
+        self.dstmac = dstmac
+        self.srcport = srcport
+        self.dstport = dstport
+        self.type = type
+        self.payload = payload
+        self.trackingid = trackingid
+        self.icmpid = icmpid
+        self.count = count
+        self.interval = interval
+        self.increment = increment
+        self.starttime = starttime
+
+    def repr_json(self):
+        obj = {}
+
+        if self.uuid:
+            obj["UUID"] = self.uuid
+        if self.src:
+            obj["Src"] = self.src
+        if self.dst:
+            obj["Dst"] = self.dst
+        if self.srcip:
+            obj["SrcIP"] = self.srcip
+        if self.dstip:
+            obj["DstIP"] = self.dstip
+        if self.srcmac:
+            obj["SrcMAC"] = self.srcmac
+        if self.dstmac:
+            obj["DstMAC"] = self.dstmac
+        if self.srcport:
+            obj["SrcPort"] = self.srcport
+        if self.dstport:
+            obj["DstPort"] = self.dstport
+        if self.type:
+            obj["Type"] = self.type
+        if self.payload:
+            obj["Payload"] = self.payload
+        if self.trackingid:
+            obj["TrackingID"] = self.trackingid
+        if self.icmpid:
+            obj["ICMPID"] = self.icmpid
+        if self.count:
+            obj["Count"] = self.count
+        if self.interval:
+            obj["Interval"] = self.interval
+        if self.increment:
+            obj["Increment"] = self.increment
+        return obj
+
+    @classmethod
+    def from_object(self, obj):
+        return self(uuid=obj.get("UUID"),
+                    src=obj.get("Src"),
+                    dst=obj.get("Dst"),
+                    srcip=obj.get("SrcIP"),
+                    dstip=obj.get("DstIP"),
+                    srcmac=obj.get("SrcMAC"),
+                    dstmac=obj.get("DstMAC"),
+                    srcport=obj.get("SrcPort"),
+                    dstport=obj.get("DstPort"),
+                    type=obj.get("Type"),
+                    payload=obj.get("Payload"),
+                    trackingid=obj.get("TrackingID"),
+                    icmpid=obj.get("ICMPID"),
+                    count=obj.get("Count"),
+                    interval=obj.get("Interval"),
+                    increment=obj.get("Increment"))

contrib/python/api/skydive/rest/client.py

@@ -31,13 +31,16 @@
 from skydive.rules import NodeRule, EdgeRule
 from skydive.alerts import Alert
 from skydive.captures import Capture
+from skydive.packet_injector import PacketInjection
 
 
 class BadRequest(Exception):
     pass
 
 
 class RESTClient:
+    INJECTION_PATH = "/api/injectpacket"
+
     def __init__(self, endpoint, scheme="http",
                  username="", password="", cookies={},
                  insecure=False, debug=0):
@@ -205,3 +208,37 @@ def edgerule_list(self):
     def edgerule_delete(self, rule_id):
         path = "/api/edgerule/%s" % rule_id
         self.request(path, method="DELETE")
+
+    def injection_create(self, src_query="", dst_query="", type="icmp4",
+                         payload="", interval=1000, src_ip="",
+                         dst_ip="", src_mac="", dst_mac="",
+                         count=1, icmp_id=0, src_port=0, dst_port=0,
+                         increment=False):
+
+        data = json.dumps({
+            "Src": src_query,
+            "Dst": dst_query,
+            "SrcPort": src_port,
+            "DstPort": dst_port,
+            "SrcIP": src_ip,
+            "DstIP": dst_ip,
+            "SrcMAC": src_mac,
+            "DstMAC": dst_mac,
+            "Type": type,
+            "Count": count,
+            "ICMPID": icmp_id,
+            "Interval": interval,
+            "Payload": payload,
+            "Increment": increment
+        })
+
+        r = self.request(self.INJECTION_PATH, method="POST", data=data)
+        return PacketInjection.from_object(r)
+
+    def injection_delete(self, injection_id):
+        path = self.INJECTION_PATH+"/"+injection_id
+        return self.request(path, method="DELETE")
+
+    def injection_list(self):
+        objs = self.request(self.INJECTION_PATH)
+        return [PacketInjection.from_object(o) for o in objs.values()]

contrib/python/api/tests/tests.py

@@ -240,7 +240,35 @@ def test_topology_rules(self):
                 break
 
         self.assertTrue(found, "created edgerule not found")
-
+        restclient.edgerule_delete(edgerule1.uuid)
         restclient.noderule_delete(noderule1.uuid)
         restclient.noderule_delete(noderule2.uuid)
-        restclient.edgerule_delete(edgerule1.uuid)
+
+    def test_injections(self):
+        restclient = RESTClient("localhost:8082",
+                                scheme=self.schemeHTTP,
+                                username=self.username,
+                                password=self.password,
+                                insecure=True)
+
+        nodes = restclient.lookup("G.V().Has('Name', 'eth0')")
+
+        testnode = nodes[0]["Metadata"]["TID"]
+
+        query = "G.V().Has('TID', '" + testnode + "')"
+        num_injections_before = len(restclient.injection_list())
+
+        injection_response = restclient.injection_create(query, query,
+                                                         count=1000)
+
+        num_injections_after = len(restclient.injection_list())
+
+        self.assertEqual(num_injections_after, num_injections_before + 1,
+                         "injection creation didn't succeed")
+
+        restclient.injection_delete(injection_response.uuid)
+
+        num_injections_after_deletion = len(restclient.injection_list())
+
+        self.assertEqual(num_injections_after_deletion, num_injections_before,
+                         "injection deletion didn't succeed")