Add default request for ephemeral storage in helm chart #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
changed the title
SeungjinYang
changed the title
| # However, when ephemeral storage is used | ||
| # (e.g. to enable rollingUpdate), | ||
| # it is recommended to set a larger value. | ||
| ephemeral-storage: "10Gi" |
There was a problem hiding this comment.
Do we still need ephemeral-storage when PVC is enabled? If not, we should not enable it by default here. Maybe we can add a field in storage to indicate persistent or ephemeral storage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where PVCs are not being used (e.g. because rollingUpdate strategy is being used), API server pod can consume a modest - large amount of ephemeral storage. Add some sensible default value for ephemeral storage to requests to values.yaml file.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)