Skip to content

Commit 8ba12a9

Browse files
author
Fil Maj
authored
chore: remove commented out old integration tests, support ref-docs (#1912)
1 parent 7bf89e6 commit 8ba12a9

File tree

16 files changed

+1
-1302
lines changed

16 files changed

+1
-1302
lines changed

.github/maintainers_guide.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Maintaining this project requires installing [Node.js](https://nodejs.org). All
1010
### ⚗️ Testing and Linting
1111
The Node SDK is made up of multiple, individual packages, each with their own tests. As such, tests are run on a per-package basis. However, the top-level directory contains some development dependencies applicable to all packages. As a result, to run tests for any package, first ensure you run `npm install` from the top-level directory. Then, for a given package, navigate to the package's directory (ie, `packages/web-api`) and run `npm install` to install that package's required dependencies. Finally, run `npm test` to run that package's tests. To run just the linting and not the entire test suite, run `npm run lint`.
1212

13-
This project has tests for individual packages as `*.spec.js` files and inside of each's package's `src` directory. It also has integration tests in the `support/integration-tests` directory.
13+
This project has tests for individual packages as `*.spec.js` files and inside of each's package's `src` directory. Also, for verifying the behavior with the real Slack server-side and developer experience with installed packages, you can run the tests amd scripts under `prod-server-integration-tests`. Refer to the README file in the directory for details. These tests are supposed to be run in the project maintainers' manual execution. They are not part of CI builds for now.
1414

1515
Upon opening a PR, tests are executed by GitHub Actions, our continuous integration system. GitHub Actions runs several, more granular builds in order to report on success and failure in a more targeted way.
1616

@@ -24,7 +24,6 @@ Test code should be written in syntax that runs on the oldest supported Node.js
2424

2525
We have included `launch.json` files that store configuration for `vscode` debugging in each package. This allows you to set breakpoints in test files and interactively debug. Open the project in `vscode` and navigate to the debug screen on the left sidebar. The icon for it looks like a little lock bug with an x inside. At the top in `vscode`, select the configuration to run and press the green play icon to start debugging. Alternatively, on mac, you can press `cmd + shift + d` to get to the debug screen and `F5` to start debugging. If you are using `vscode` debugging, don't forget to lint the source (`npm run lint`) manually.
2626

27-
Also, for verifying the behavior with the real Slack server-side and developer experience with installed packages, you can run the tests amd scripts under `prod-server-integration-tests`. Refer to the README file in the directory for details. These tests are supposed to be run in the project maintainers' manual execution. They are not part of CI builds for now.
2827

2928
### 📄 Managing Documentation
3029

integration-tests/.vscode/launch.json

Lines changed: 0 additions & 39 deletions
This file was deleted.

support/integration-tests/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

support/integration-tests/README.md

Lines changed: 0 additions & 28 deletions
This file was deleted.

support/integration-tests/package.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

support/integration-tests/proxy-test.js

Lines changed: 0 additions & 98 deletions
This file was deleted.

support/ref-docs/.gitignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

support/ref-docs/models/.gitkeep

Whitespace-only changes.

support/ref-docs/package.json

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)