Finalize L11 (#16)

slashequip · web-flow · commit d47264a7af94 · 2024-05-20T21:37:25.000+01:00
* Tests for L11 and PHP8.3

* Fix styling

* Fix

* No PHP 8.1

* Update pest

* Update psalm

* ergh matrixes are hard…

* Latest only for tests

* wip

---------

Co-authored-by: slashequip &lt;slashequip@users.noreply.github.com&gt;
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -9,14 +9,12 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        php: [8.1, 8.2]
-        laravel: [9.*, 10.*]
+        php: [8.3]
+        laravel: [11.*]
         stability: [prefer-stable]
         include:
-          - laravel: 9.*
-            testbench: 7.*
-          - laravel: 10.*
-            testbench: 8.*
+          - laravel: 11.*
+            testbench: 9.*
 
     name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}
 
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,4 @@
 /composer.lock
 /build
 /.php_cs.cache
+/.phpunit.cache
diff --git a/composer.json b/composer.json
@@ -22,10 +22,9 @@
         "laravel/pint": "^1.10",
         "mockery/mockery": "^1.4",
         "nunomaduro/larastan": "^2.0",
-        "orchestra/testbench": "^7.25|^8.5",
-        "pestphp/pest": "^1.0",
-        "phpunit/phpunit": "^9.3",
-        "vimeo/psalm": "^4.6"
+        "orchestra/testbench": "^7.25|^8.5|^9.0",
+        "pestphp/pest": "^2.0",
+        "vimeo/psalm": "^5.24"
     },
     "autoload": {
         "psr-4": {
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,39 +1,23 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
-    backupGlobals="false"
-    backupStaticAttributes="false"
-    bootstrap="vendor/autoload.php"
-    colors="true"
-    convertErrorsToExceptions="true"
-    convertNoticesToExceptions="true"
-    convertWarningsToExceptions="true"
-    processIsolation="false"
-    stopOnFailure="false"
-    executionOrder="random"
-    failOnWarning="true"
-    failOnRisky="true"
-    failOnEmptyTestSuite="true"
-    beStrictAboutOutputDuringTests="true"
-    verbose="true"
->
-    <testsuites>
-        <testsuite name="Laravel Segment Test Suite">
-            <directory>tests</directory>
-        </testsuite>
-    </testsuites>
-    <coverage>
-        <include>
-            <directory suffix=".php">./src</directory>
-        </include>
-        <report>
-            <html outputDirectory="build/coverage"/>
-            <text outputFile="build/coverage.txt"/>
-            <clover outputFile="build/logs/clover.xml"/>
-        </report>
-    </coverage>
-    <logging>
-        <junit outputFile="build/report.junit.xml"/>
-    </logging>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" executionOrder="random" failOnWarning="true" failOnRisky="true" failOnEmptyTestSuite="true" beStrictAboutOutputDuringTests="true" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
+  <testsuites>
+    <testsuite name="Laravel Segment Test Suite">
+      <directory>tests</directory>
+    </testsuite>
+  </testsuites>
+  <coverage>
+    <report>
+      <html outputDirectory="build/coverage"/>
+      <text outputFile="build/coverage.txt"/>
+      <clover outputFile="build/logs/clover.xml"/>
+    </report>
+  </coverage>
+  <logging>
+    <junit outputFile="build/report.junit.xml"/>
+  </logging>
+  <source>
+    <include>
+      <directory suffix=".php">./src</directory>
+    </include>
+  </source>
 </phpunit>
diff --git a/phpunit.xml.dist.bak b/phpunit.xml.dist.bak
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
+    backupGlobals="false"
+    backupStaticAttributes="false"
+    bootstrap="vendor/autoload.php"
+    colors="true"
+    convertErrorsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertWarningsToExceptions="true"
+    processIsolation="false"
+    stopOnFailure="false"
+    executionOrder="random"
+    failOnWarning="true"
+    failOnRisky="true"
+    failOnEmptyTestSuite="true"
+    beStrictAboutOutputDuringTests="true"
+    verbose="true"
+>
+    <testsuites>
+        <testsuite name="Laravel Segment Test Suite">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+    <coverage>
+        <include>
+            <directory suffix=".php">./src</directory>
+        </include>
+        <report>
+            <html outputDirectory="build/coverage"/>
+            <text outputFile="build/coverage.txt"/>
+            <clover outputFile="build/logs/clover.xml"/>
+        </report>
+    </coverage>
+    <logging>
+        <junit outputFile="build/report.junit.xml"/>
+    </logging>
+</phpunit>
diff --git a/src/Contracts/SegmentServiceContract.php b/src/Contracts/SegmentServiceContract.php
@@ -16,12 +16,12 @@ public function setGlobalContext(array $globalContext): void;
     /**
      * @param  array<string, mixed>  $eventData
      */
-    public function track(string $event, array $eventData = null): void;
+    public function track(string $event, ?array $eventData = null): void;
 
     /**
      * @param  array<string, mixed>  $identifyData
      */
-    public function identify(array $identifyData = null): void;
+    public function identify(?array $identifyData = null): void;
 
     public function forUser(CanBeIdentifiedForSegment $user): PendingUserSegment;
 
diff --git a/src/Facades/Fakes/SegmentFake.php b/src/Facades/Fakes/SegmentFake.php
@@ -49,7 +49,7 @@ public function identify(?array $identifyData = []): void
     /**
      * @param  array<string, mixed>  $eventData
      */
-    public function track(string $event, array $eventData = null): void
+    public function track(string $event, ?array $eventData = null): void
     {
         $this->events[] = new SimpleSegmentEvent($this->user, $event, $eventData);
     }
@@ -76,7 +76,7 @@ public function terminate(): void
     {
     }
 
-    public function assertIdentified(Closure|int $callback = null): void
+    public function assertIdentified(Closure|int|null $callback = null): void
     {
         if (is_numeric($callback)) {
             $this->assertIdentifiedTimes($callback);
@@ -100,7 +100,7 @@ public function assertIdentifiedTimes(int $times = 1): void
         );
     }
 
-    public function assertNotIdentified(Closure $callback = null): void
+    public function assertNotIdentified(?Closure $callback = null): void
     {
         PHPUnit::assertCount(
             0, $this->identities($callback),
@@ -115,7 +115,7 @@ public function assertNothingIdentified(): void
         PHPUnit::assertEmpty($identities, $identities->count().' events were found unexpectedly.');
     }
 
-    public function assertTracked(Closure|int $callback = null): void
+    public function assertTracked(Closure|int|null $callback = null): void
     {
         if (is_numeric($callback)) {
             $this->assertTrackedTimes($callback);
@@ -139,23 +139,23 @@ public function assertTrackedTimes(int $times = 1): void
         );
     }
 
-    public function assertEventTracked(string $event, Closure|int $callback = null): void
+    public function assertEventTracked(string $event, Closure|int|null $callback = null): void
     {
         PHPUnit::assertTrue(
             $this->events($callback, $event)->count() > 0,
             'The expected events were not called.'
         );
     }
 
-    public function assertNotTracked(Closure $callback = null): void
+    public function assertNotTracked(?Closure $callback = null): void
     {
         PHPUnit::assertCount(
             0, $this->events($callback),
             'The unexpected event was called.'
         );
     }
 
-    public function assertEventNotTracked(string $event, Closure|int $callback = null): void
+    public function assertEventNotTracked(string $event, Closure|int|null $callback = null): void
     {
         PHPUnit::assertCount(
             0, $this->events($callback, $event),
@@ -178,7 +178,7 @@ public function getContext(): ?array
         return $this->context;
     }
 
-    private function identities(Closure $callback = null): Collection
+    private function identities(?Closure $callback = null): Collection
     {
         $identities = collect($this->identities);
 
@@ -191,7 +191,7 @@ private function identities(Closure $callback = null): Collection
         return $identities->filter(fn (SimpleSegmentIdentify $identity) => $callback($identity));
     }
 
-    private function events(Closure $callback = null, string $event = null): Collection
+    private function events(?Closure $callback = null, ?string $event = null): Collection
     {
         $events = collect($this->events);
 
diff --git a/src/PendingUserSegment.php b/src/PendingUserSegment.php
@@ -20,7 +20,7 @@ public function __construct(SegmentServiceContract $service, CanBeIdentifiedForS
     /**
      * @param  array<string, mixed>|null  $eventData
      */
-    public function track(string $event, array $eventData = null): void
+    public function track(string $event, ?array $eventData = null): void
     {
         $this->service->push(
             new SimpleSegmentEvent($this->user, $event, $eventData)
@@ -30,7 +30,7 @@ public function track(string $event, array $eventData = null): void
     /**
      * @param  array<string, mixed>|null  $identifyData
      */
-    public function identify(array $identifyData = null): void
+    public function identify(?array $identifyData = null): void
     {
         $this->service->push(
             new SimpleSegmentIdentify($this->user, $identifyData)
diff --git a/src/SegmentService.php b/src/SegmentService.php
@@ -47,7 +47,7 @@ public function setGlobalContext(array $globalContext): void
     /**
      * @param  array<string, mixed>  $eventData
      */
-    public function track(string $event, array $eventData = null): void
+    public function track(string $event, ?array $eventData = null): void
     {
         $this->push(
             new SimpleSegmentEvent($this->globalUser, $event, $eventData)
@@ -57,7 +57,7 @@ public function track(string $event, array $eventData = null): void
     /**
      * @param  array<string, mixed>  $identifyData
      */
-    public function identify(array $identifyData = null): void
+    public function identify(?array $identifyData = null): void
     {
         $this->push(
             new SimpleSegmentIdentify($this->globalUser, $identifyData)
diff --git a/src/ValueObjects/SegmentPayload.php b/src/ValueObjects/SegmentPayload.php
@@ -19,7 +19,7 @@ public function __construct(
         public readonly SegmentPayloadType $type,
         public readonly ?string $event = null,
         public readonly array $data = [],
-        DateTime $timestamp = null
+        ?DateTime $timestamp = null
     ) {
         $this->timestamp = $timestamp ?: new DateTime();
         $this->timestamp->setTimezone(new DateTimeZone('UTC'));

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function identify(?array $identifyData = []): void`
`49`	`49`	`/**`
`50`	`50`	`* @param array<string, mixed> $eventData`
`51`	`51`	`*/`
`52`		`- public function track(string $event, array $eventData = null): void`
	`52`	`+ public function track(string $event, ?array $eventData = null): void`
`53`	`53`	`{`
`54`	`54`	`$this->events[] = new SimpleSegmentEvent($this->user, $event, $eventData);`
`55`	`55`	`}`
`@@ -76,7 +76,7 @@ public function terminate(): void`
`76`	`76`	`{`
`77`	`77`	`}`
`78`	`78`
`79`		`- public function assertIdentified(Closure\|int $callback = null): void`
	`79`	`+ public function assertIdentified(Closure\|int\|null $callback = null): void`
`80`	`80`	`{`
`81`	`81`	`if (is_numeric($callback)) {`
`82`	`82`	`$this->assertIdentifiedTimes($callback);`
`@@ -100,7 +100,7 @@ public function assertIdentifiedTimes(int $times = 1): void`
`100`	`100`	`);`
`101`	`101`	`}`
`102`	`102`
`103`		`- public function assertNotIdentified(Closure $callback = null): void`
	`103`	`+ public function assertNotIdentified(?Closure $callback = null): void`
`104`	`104`	`{`
`105`	`105`	`PHPUnit::assertCount(`
`106`	`106`	`0, $this->identities($callback),`
`@@ -115,7 +115,7 @@ public function assertNothingIdentified(): void`
`115`	`115`	`PHPUnit::assertEmpty($identities, $identities->count().' events were found unexpectedly.');`
`116`	`116`	`}`
`117`	`117`
`118`		`- public function assertTracked(Closure\|int $callback = null): void`
	`118`	`+ public function assertTracked(Closure\|int\|null $callback = null): void`
`119`	`119`	`{`
`120`	`120`	`if (is_numeric($callback)) {`
`121`	`121`	`$this->assertTrackedTimes($callback);`
`@@ -139,23 +139,23 @@ public function assertTrackedTimes(int $times = 1): void`
`139`	`139`	`);`
`140`	`140`	`}`
`141`	`141`
`142`		`- public function assertEventTracked(string $event, Closure\|int $callback = null): void`
	`142`	`+ public function assertEventTracked(string $event, Closure\|int\|null $callback = null): void`
`143`	`143`	`{`
`144`	`144`	`PHPUnit::assertTrue(`
`145`	`145`	`$this->events($callback, $event)->count() > 0,`
`146`	`146`	`'The expected events were not called.'`
`147`	`147`	`);`
`148`	`148`	`}`
`149`	`149`
`150`		`- public function assertNotTracked(Closure $callback = null): void`
	`150`	`+ public function assertNotTracked(?Closure $callback = null): void`
`151`	`151`	`{`
`152`	`152`	`PHPUnit::assertCount(`
`153`	`153`	`0, $this->events($callback),`
`154`	`154`	`'The unexpected event was called.'`
`155`	`155`	`);`
`156`	`156`	`}`
`157`	`157`
`158`		`- public function assertEventNotTracked(string $event, Closure\|int $callback = null): void`
	`158`	`+ public function assertEventNotTracked(string $event, Closure\|int\|null $callback = null): void`
`159`	`159`	`{`
`160`	`160`	`PHPUnit::assertCount(`
`161`	`161`	`0, $this->events($callback, $event),`
`@@ -178,7 +178,7 @@ public function getContext(): ?array`
`178`	`178`	`return $this->context;`
`179`	`179`	`}`
`180`	`180`
`181`		`- private function identities(Closure $callback = null): Collection`
	`181`	`+ private function identities(?Closure $callback = null): Collection`
`182`	`182`	`{`
`183`	`183`	`$identities = collect($this->identities);`
`184`	`184`
`@@ -191,7 +191,7 @@ private function identities(Closure $callback = null): Collection`
`191`	`191`	`return $identities->filter(fn (SimpleSegmentIdentify $identity) => $callback($identity));`
`192`	`192`	`}`
`193`	`193`
`194`		`- private function events(Closure $callback = null, string $event = null): Collection`
	`194`	`+ private function events(?Closure $callback = null, ?string $event = null): Collection`
`195`	`195`	`{`
`196`	`196`	`$events = collect($this->events);`
`197`	`197`