lesson-5 unable to deploy 'addPerson' function

[TimeKeyRoll]

Hi! I am trying to write addPerson function in deploy but it's showing me an error. Anyone else has experienced this?
Please help if someone knows.
thankyou.

[RoboCrypter]

@MasterofBlockchain your repo link please.. I will look into it.

[TimeKeyRoll]

SimpleStorage

// SPDX-License-Identifier: MIT

pragma solidity ^0.8.8;

contract SimpleStorage {
    uint256 favoriteNumber;

    struct People {
        uint256 favoriteNumber;
        string name;
    }

    People[] public people;

    mapping(string => uint256) public nameToFavoriteNumber;

    //used the virtual keyword so this contract is being inherited
    //in another account.

    function store(uint256 _favoriteNumber) public virtual {
        favoriteNumber = _favoriteNumber;
    }

    function retrieve() public view returns (uint256) {
        return favoriteNumber;
    }

    function addPerson(string memory _name, uint256 _favoriteNumber) public {
        //1- push array in first way
        //People memory newPerson  =  People ({favoriteNumber: _favoriteNumber, name:_name});
        //people.push(newPerson);

        // push array in second way
        people.push(People(_favoriteNumber, _name)); //array
        nameToFavoriteNumber[_name] = _favoriteNumber; //mapping
    }
}

[TimeKeyRoll]

deploy.js

const { ethers, network, run } = require("hardhat")

async function main() {
    const SimpleStoragefactory = await ethers.getContractFactory(
        "SimpleStorage"
    )
    console.log("deployin contract...")

    const SimpleStorage = await SimpleStoragefactory.deploy()

    await SimpleStorage.deployed()
    console.log(`contract addddress is ${SimpleStorage.address}`)

    if (network.config.chainId == 5 && process.env.ETHERSCAN_API_KEY) {
        console.log("waiting for the block tx...")
        await SimpleStorage.deployTransaction.wait(6)
        //await verify(SimpleStorage.address, [])
    }

    const currentValue = await SimpleStorage.retrieve()
    console.log(`current no is : ${currentValue}`)

    const transResponse = await SimpleStorage.store(7)
    await transResponse.wait(1)

    const updatdvalue = await SimpleStorage.retrieve()
    console.log(`update no is ${updatdvalue}`)

    const AddPerson = await SimpleStorage.addPerson()
    //console.log(`add person is : ${AddPerson}`)

    const transRsponse = await SimpleStorage.addPerson("Doggy", "66")
    const transReceipt = await transResponse.wait(1)

    const updatedvalue = await SimpleStorage.addPerson(transRsponse)
    console.log(`update value is : ${updatedvalue}`)
}

async function verify(contractAddress, args) {
    console.log("verifyin conatract ....")
    try {
        await run("verify:verify", {
            address: contractAddress,
            constructorArguments: args,
        })
    } catch (e) {
        if (e.message.toLowerCase().includes("already verified")) {
            console.log("Already Verified!")
        } else {
            console.log(e)
        }
    }
}

main()
    .then(() => process.exit(0))
    .catch((error) => {
        console.error(error)
        process.exit(1)
    })

[TimeKeyRoll]

I don't have a repo for this.
But i think there is something missing as per the error. And i am not sure what's that?
I sent the screenshot of it. If you can see the deploy script that might could help.

[TimeKeyRoll]

I did remove. But I am seeing the same error. Lol

[RoboCrypter]

Alright then now, I have to test your deploy script myself I will let you know when I am done.

[TimeKeyRoll]

Thank you very much

[RoboCrypter]

@MasterofBlockchain I'm done debugging.

and it will for sure work ...

[RoboCrypter]

copy paste my deploy script I made some changes..

And Have a good day...

[RoboCrypter]

deploy.js

const { ethers, network, run } = `require("hardhat")`
async function main() {
    const SimpleStoragefactory = await ethers.getContractFactory("SimpleStorage")
    console.log("deployin contract...")

    const SimpleStorage = await SimpleStoragefactory.deploy()

    await SimpleStorage.deployed()
    console.log(`contract addddress is ${SimpleStorage.address}`)

    if (network.config.chainId == 5 && process.env.ETHERSCAN_API_KEY) {
        console.log("waiting for the block tx...")
        await SimpleStorage.deployTransaction.wait(6)
        //await verify(SimpleStorage.address, [])
    }

    const currentValue = await SimpleStorage.retrieve()
    console.log(`current no is : ${currentValue}`)

    const transResponse = await SimpleStorage.store(7)
    await transResponse.wait(1)

    const updatdvalue = await SimpleStorage.retrieve()
    console.log(`update no is ${updatdvalue}`)

    const addPerson = await SimpleStorage.addPerson("doggy", "22")
    const peopleArray = await SimpleStorage.people(0)

    await addPerson.wait(1)

    console.log(`update value is : ${peopleArray}`)
}

async function verify(contractAddress, args) {
    console.log("verifyin conatract ....")
    try {
        await run("verify:verify", {
            address: contractAddress,
            constructorArguments: args,
        })
    } catch (e) {
        if (e.message.toLowerCase().includes("already verified")) {
            console.log("Already Verified!")
        } else {
            console.log(e)
        }
    }
}

main()
    .then(() => process.exit(0))
    .catch((error) => {
        console.error(error)
        process.exit(1)
    }) 

[TimeKeyRoll]

I would love to. Kindly guide me how to do that?

[RoboCrypter]

@MasterofBlockchain Go to my answer, In the upper-right corner of the answer comment, there will be a tick mark , just checked it

ThankYou!

[TimeKeyRoll]

I am sorry. there is option to close this. or could you send me a picture of it so i could find too?

[RoboCrypter]

My mistake I forgot you opened a general discussion not a Q&A discussion.

Have a good one...

[TimeKeyRoll]

haha it's okay but thankyou again.

[waleedcj]

line No.29 is redundant so remove it. Also, it does not have two-string parameters
also, in line 35, the way you are updating, "doggy" and 66 are already added in the mapping, and you are adding them again in the wrong way remember, addPerson only can take in string and unit; try using the function "nameToFavoriteNumber(" String Name of the person added")

[TimeKeyRoll]

Tried that way too and could not figure. Still trying a way to fix it. Lol