Lesson 7: yarn hardhat deploy --tags mocks -> returns error [SOLVED]

[DorianDaSilva]

yarn hardhat deploy --tags mocks

returns

Error: expected 0 constructor arguments, got 2

after running line

local detected! Deploying mocks...
An unexpected error occurred:

Checked my code several times but all seems identical to video lesson. Help plz!

[Magofoco]

Can you show us the solidity code?

Also, try to delete the cache and the artifacts and try to compile again

[DorianDaSilva]

@Magofoco Below is the solidity code for 00-deploy.mocks.js

const { network } = require("hardhat");
const {
  developmentChains,
  DECIMALS,
  INITIAL_ANSWER,
} = require("../helper-hardhat-config");

module.exports = async ({ getNamedAccounts, deployments }) => {
  const { deploy, log } = deployments;
  const { deployer } = await getNamedAccounts();
  if (developmentChains.includes(network.name)) {
    log("local detected! Deploying mocks...");
    await deploy("MockV3Aggregator", {
      contract: "MockV3Aggregator",
      from: deployer,
      log: true,
      args: [DECIMALS, INITIAL_ANSWER],
    });
    log("Mocks deployed!");
    log("-------------------------------------------------------")

  }
};

module.exports.tags = ["all", "mocks"]

helper-hardhat-config.js

const developmentChains = ["hardhat", "localhost"];
const DECIMALS = 8;
const INITIAL_ANSWER = 200000000000; //2000 + 8 decimals

module.exports = {
  networkConfig,
  developmentChains,
  DECIMALS,
  INITIAL_ANSWER,
};

[DorianDaSilva]

@Magofoco Also deleted the artifact and cache files then recompiled but error persists

[Magofoco]

Can you post the code ending in .sol, you post the one ending in .js. The solidity code ends in .sol, the JavaScript in .js

[DorianDaSilva]

@Magofoco Here is the MockV3Aggregator.sol code

//SPDX-License-Identifier:MIT
pragma solidity ^0.8.12;


import "./AggregatorV2V3Interface.sol";

abstract contract MockV3Aggregator is AggregatorV2V3Interface {
  uint256 public constant override version = 0;

  uint8 public override decimals;
  int256 public override latestAnswer;
  uint256 public override latestTimestamp;
  uint256 public override latestRound;

  mapping(uint256 => int256) public override getAnswer;
  mapping(uint256 => uint256) public override getTimestamp;
  mapping(uint256 => uint256) private getStartedAt;

  constructor(uint8 _decimals, int256 _initialAnswer) {
    decimals = _decimals;
    updateAnswer(_initialAnswer);
  }

  function updateAnswer(int256 _answer) public {
    latestAnswer = _answer;
    latestTimestamp = block.timestamp;
    latestRound++;
    getAnswer[latestRound] = _answer;
    getTimestamp[latestRound] = block.timestamp;
    getStartedAt[latestRound] = block.timestamp;
  }

  function updateRoundData(
    uint80 _roundId,
    int256 _answer,
    uint256 _timestamp,
    uint256 _startedAt
  ) public {
    latestRound = _roundId;
    latestAnswer = _answer;
    latestTimestamp = _timestamp;
    getAnswer[latestRound] = _answer;
    getTimestamp[latestRound] = _timestamp;
    getStartedAt[latestRound] = _startedAt;
  }

  function getRoundData(uint80 _roundId)
    external
    view
    override
    returns (
      uint80 roundId,
      int256 answer,
      uint256 startedAt,
      uint256 updatedAt,
      uint80 answeredInRound
    )
  {
    return (_roundId, getAnswer[_roundId], getStartedAt[_roundId], getTimestamp[_roundId], _roundId);
  }

  function latestRoundData()
    external
    view
    override
    returns (
      uint80 roundId,
      int256 answer,
      uint256 startedAt,
      uint256 updatedAt,
      uint80 answeredInRound
    )
  {
    return (
      uint80(latestRound),
      getAnswer[latestRound],
      getStartedAt[latestRound],
      getTimestamp[latestRound],
      uint80(latestRound)
    );
  }

  function description() external pure override returns (string memory) {
    return "v0.8/tests/MockV3Aggregator.sol";
  }
}

I tried adding MockV3Aggregator to helper-hardhat-config.js and import it that way into deploy-mocks but it seems I may have made a mistake since it didn't work

[Magofoco]

And do you have one contract called FundMe.sol?

If you check the github repo of lesson 7, I think you are missing some code parts.
https://github.com/PatrickAlphaC/hardhat-fund-me-fcc

[DorianDaSilva]

@Magofoco I am using the same FundMe deployed in earlier lessons. Besides the issue here is with MockV3Aggregator constructor arguments which are identical in all versions. So not sure what the problem is, still trying to fix it, hoping to be able to complete the lesson.

[DorianDaSilva]

@Magofoco

//SPDX-License-Identifier: MIT
pragma solidity ^0.8.12;

//import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "./test/AggregatorV3Interface.sol";
import "./PriceConverter.sol";

error NotOwner();
error NotSuccess();

contract FundMe {
    using PriceConverter for uint256;

    uint256 public constant MINIMUM_USD = 50 * 1e18; //1 * 10 ** 18

    address[] public funders;
    mapping(address => uint256) public addressToAmountFunded;

    address public immutable i_owner;
    AggregatorV3Interface public priceFeed;

    constructor(address priceFeedAddress){
        i_owner = msg.sender;
        priceFeed = AggregatorV3Interface(priceFeedAddress);
    }


    function fund() public payable{
        require(msg.value.getConversionRate(priceFeed) >= MINIMUM_USD, "Didn't send enough");
        funders.push(msg.sender);
        addressToAmountFunded[msg.sender] = msg.value;
    }

    function withdraw() public onlyOwner {

        for(uint256 funderIndex = 0; funderIndex < funders.length; funderIndex = funderIndex + 1){
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
//reset the array
        funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
        require(callSuccess, "Call failed");
    }

    modifier onlyOwner {
        if(msg.sender != i_owner) { revert NotOwner();}
        _;
    }

    receive() external payable {
        fund();
    }

    fallback() external payable {
        fund();
    }

}

[DorianDaSilva]

@Magofoco But it seems to me that deploy-mocks.js isn't calling from fundme.sol so not sure if the code in fundme has any effect on the outcome deploying mocks

[DorianDaSilva]

@Magofoco Solved it! Solution below. Thank you for the input, much appreciated!

Solved by editing abi in the MockV3Aggregator.json file located in artefacts

artefacts > tests > MockV3Aggregator > MockV3Aggregator.json

  "abi": [
    {
      "type": "constructor",
      "payable": false,
      "inputs": [
        {
          "type": "uint8",
          "name": "decimals"
        },
        {
          "type": "int256",
          "name": "initialAnswer"
        }
      ]
    },