Skip to content

Commit 014401c

Browse files
authored
Merge pull request #1139 from smartdevicelink/hotfix/fix_vr_optional
Hotfix 4.9.1 - Fix ChoiceSetManager issue with HUs that require VR for choices
2 parents df717f0 + 84a48b0 commit 014401c

File tree

5 files changed

+9
-29
lines changed

5 files changed

+9
-29
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
language: android
22
jdk: oraclejdk8
3+
dist: trusty
34
sudo: false
45
android:
56
components:

CHANGELOG.md

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,5 @@
1-
# 4.9.0 Release Notes
1+
# 4.9.1 Release Notes
22

3-
## Feature
3+
### Hotfix
44

5-
- [[SDL 0157] Mobile Choice Set Manager](https://github.com/smartdevicelink/sdl_java_suite/issues/764)
6-
- [[SDL 0155] Mobile Menu Manager](https://github.com/smartdevicelink/sdl_java_suite/issues/730)
7-
- [[SDL 0210]-Mobile Manager Dynamic Menu Cell Updating ](https://github.com/smartdevicelink/sdl_java_suite/issues/961)
8-
- [[SDL 0232] Added Pushing Buffer Support to AudioStreamManager](https://github.com/smartdevicelink/sdl_java_suite/issues/1075)
9-
- [Library will dynamically check if head unit requires VR synonyms for Choice items](https://github.com/smartdevicelink/sdl_java_suite/issues/941)
10-
- [VideoStreamingManager now fully supports multi-touch events](https://github.com/smartdevicelink/sdl_java_suite/issues/972)
11-
12-
13-
14-
## Bug Fixes
15-
16-
- [Symlinks broken on Windows](https://github.com/smartdevicelink/sdl_java_suite/issues/1062) - Windows user must run a gradle task (`buildWindowSymLinks`) in order to create the Windows version of symlinks.
17-
- [Audio over AOA Issues](https://github.com/smartdevicelink/sdl_java_suite/issues/1056) - Media apps will now wait until an audio output device is ready before connecting over a transport. This can be overwritten by the developer.
18-
- [Fixed LeftRearInflatableBelted using the wrong key value in BeltStatus Class](https://github.com/smartdevicelink/sdl_java_suite/issues/1078)
19-
- [New Router Service and old USB Transport compatibility issues](https://github.com/smartdevicelink/sdl_java_suite/issues/1064) - Fixed an issue that caused apps not close when a legacy AOA app was chosen by the user.
20-
- [Fixed an issue with `sendSequentialRPCs` where it didn't call `onResponse` and stoped on first `onError`](https://github.com/smartdevicelink/sdl_java_suite/issues/1061)
21-
22-
## Misc
23-
- [Updated library to use the newest BSON library](https://github.com/smartdevicelink/sdl_java_suite/pull/1072)
24-
- [Update gradle plugin](https://github.com/smartdevicelink/sdl_java_suite/pull/1077)
5+
- [Fix ChoiceSetManager issue with HUs that require VR for choices](https://github.com/smartdevicelink/sdl_java_suite/issues/1137)

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.9.0
1+
4.9.1

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/CheckChoiceVROptionalOperation.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,15 @@ public void onResponse(int correlationId, RPCResponse response) {
8080
isVROptional = true;
8181
deleteTestChoiceSet();
8282
}else{
83+
DebugTool.logWarning("Head unit doesn't support choices with no VR.");
8384
sendTestChoiceWithVR();
8485
}
8586
}
8687

8788
@Override
8889
public void onError(int correlationId, Result resultCode, String info){
89-
DebugTool.logError("There was an error in the check choice vr optional operation. Send test choice with no VR failed. Error: " + info + " resultCode: " + resultCode);
90-
isVROptional = false;
91-
if (checkChoiceVROptionalInterface != null){
92-
checkChoiceVROptionalInterface.onError(info);
93-
}
90+
DebugTool.logWarning("Head unit doesn't support choices with no VR. Error: " + info + " resultCode: " + resultCode);
91+
sendTestChoiceWithVR();
9492
}
9593
});
9694

javaSE/src/main/java/com/smartdevicelink/BuildConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232

3333
// THIS FILE IS AUTO GENERATED, DO NOT MODIFY!!
3434
public final class BuildConfig {
35-
public static final String VERSION_NAME = "4.9.0";
35+
public static final String VERSION_NAME = "4.9.1";
3636
}

0 commit comments

Comments
 (0)