Merge pull request #205 from smartobjectoriented/200-so3-boot-is-blocking-on-rpi4-64bits

200 so3 boot is blocking on rpi4 64bits

Author: daniel-rossier

so3/arch/arm64/exception.S

@@ -226,7 +226,7 @@ ENTRY(pre_ret_to_el1_with_spin)
 	// Set the CPU in EL1 mode to proceed with
 	// the bootstrap of the domain
 
-	mov	x2, #PSR_MODE_EL1t
+	mov	x2, #PSR_MODE_EL1h
 
 	// Make sure no interrupt coming from CPU #0 is
 	// interferring with other CPU bootstrap
@@ -271,7 +271,7 @@ ENTRY(pre_ret_to_el1)
 	// Set the CPU in EL1 mode to proceed with
 	// the bootstrap of the domain
 
-	mov	x2, #PSR_MODE_EL1t
+	mov	x2, #PSR_MODE_EL1h
 
 	// Make sure no interrupt coming from CPU #0 is
 	// interferring with other CPU bootstrap

so3/arch/arm64/head.S

@@ -424,7 +424,7 @@ install_el2_stub:
 	msr	vbar_el2, x0
 
 	/* spsr */
-	mov	x0, #(PSR_F_BIT | PSR_I_BIT | PSR_A_BIT | PSR_D_BIT | PSR_MODE_EL1t)
+	mov	x0, #(PSR_F_BIT | PSR_I_BIT | PSR_A_BIT | PSR_D_BIT | PSR_MODE_EL1h)
 	msr	spsr_el2, x0
 	msr	elr_el2, lr
 	mov	w0, #BOOT_CPU_MODE_EL2		// This CPU booted in EL2

so3/arch/arm64/mmu.c

@@ -22,14 +22,16 @@
 #include <sizes.h>
 #include <string.h>
 #include <process.h>
-#include <log.h>
 
 #include <device/ramdev.h>
 #include <device/fdt.h>
 
 #include <asm/mmu.h>
 #include <asm/cacheflush.h>
 
+#undef LOG_DEBUG
+#define LOG_DEBUG(fmt, ...)
+
 void *__current_pgtable = NULL;
 
 void *current_pgtable(void)
@@ -603,6 +605,7 @@ void reset_root_pgtable(void *pgtable, bool remove)
  */
 void mmu_configure(addr_t fdt_addr)
 {
+	/* clang-format off */
 	int i;
 
 	icache_disable();
@@ -691,6 +694,8 @@ void mmu_configure(addr_t fdt_addr)
 
 	icache_enable();
 	dcache_enable();
+
+	/* clang-format on */
 }
 
 /*

so3/arch/arm64/traps.c

@@ -117,6 +117,8 @@ typedef void (*vector_fn_t)(cpu_regs_t *);
 
 void trap_handle(cpu_regs_t *regs)
 {
+	int ret = 0;
+
 #ifndef CONFIG_AVZ
 	syscall_args_t sys_args;
 #endif
@@ -140,7 +142,9 @@ void trap_handle(cpu_regs_t *regs)
 	switch (ESR_ELx_EC(esr)) {
 	case ESR_ELx_EC_DABT_LOW:
 
-		dabt_handle(regs, esr);
+		ret = dabt_handle(regs, esr);
+		if (ret == -1)
+			goto __err;
 		break;
 
 	/* SVC used for syscalls */
@@ -246,6 +250,7 @@ void trap_handle(cpu_regs_t *regs)
 #endif
 
 	default:
+__err:
 		lprintk("### On CPU %d: ESR_Elx_EC(esr): 0x%lx\n", smp_processor_id(), ESR_ELx_EC(esr));
 		trap_handle_error(regs->lr);
 		kernel_panic();

so3/kernel/schedule.c

@@ -444,7 +444,8 @@ void schedule(void)
 		LOG_DEBUG("Now scheduling thread ID: %d name: %s PID: %d prio: %d\n", next->tid, next->name,
 			  ((next->pcb != NULL) ? next->pcb->pid : -1), next->prio);
 		if (prev)
-			LOG_DEBUG("Previous was threadID: %d name: %s PID: %d\n", prev->tid, prev->name);
+			LOG_DEBUG("Previous was threadID: %d name: %s PID: %d\n", prev->tid, prev->name,
+				  (next->pcb != NULL) ? next->pcb->pid : -1);
 
 		/*
 		 * The current threads (here prev) can be in different states, not only running; it may be in *waiting* or *zombie*

so3/mm/memory.c

@@ -54,6 +54,13 @@ static uint32_t kernel_size;
 /* Current available I/O range address */
 struct list_head io_maplist;
 
+/**
+ * @brief This function is called early during the bootstrap by head.S
+ * 	  There is no MMU activated and all adresses are physical.
+ * 	  DO NOT PRINT ANYTHING IN THIS FUNCTION.
+ * 
+ * @param fdt_paddr 
+ */
 void early_memory_init(void *fdt_paddr)
 {
 	int offset;
@@ -64,9 +71,6 @@ void early_memory_init(void *fdt_paddr)
 #ifndef CONFIG_AVZ
 	__fdt_addr = (void *) __va(fdt_paddr);
 #endif
-
-	if (offset >= 0)
-		LOG_DEBUG("Found %d MB of RAM at 0x%08X", mem_info.size / SZ_1M, mem_info.phys_base);
 }
 
 uint32_t get_kernel_size(void)

usr/lib/libc/exit/exit.c

@@ -27,8 +27,16 @@ weak_alias(libc_exit_fini, __libc_exit_fini);
 
 _Noreturn void exit(int code)
 {
+	#warning exit() issue
+	/* 
+	 * Currently, the following code leads to data abort fault randomly. The effect
+	 * is visible on RPi4 (64-bit) more rarely on virt64
+	 */
+#if 0
 	__funcs_on_exit();
-	__libc_exit_fini();
+	__libc_exit_fini();	
 	__stdio_exit();
+#endif /* 0 */
+
 	_Exit(code);
 }