Skip to content

Newest 1.6.0 breaks support for streaming large JSON resultsets #234

@tobia

Description

@tobia

Up until version 1.5.3 we were using Client::streamRead() in order to read very large JSON resultsets (hundreds of MB) which would crash PHP if you attempted to json_decode() them.

This no longer works in 1.6.0, because now it always calls json_decode() behind the scenes, even when using streamRead()

This is because Client::streamRead() calls Transport\Http::streamRead() which calls Transport\Http::streaming() which creates a Statement and calls Statement::isError() which calls Statement::hasErrorClickhouse() which now does a full json_decode() of the response whenever the response is of JSON type.

Could you please remove this additional JSON decoding inside hasErrorClickhouse() or provide an option to turn it off?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions