Enable some errors that were suppressed for 1.82

Note we expect some failures here, at least until the following are merged:

#4125

#4146

Author: landonxjames

buildSrc/src/main/kotlin/CodegenTestCommon.kt

@@ -291,7 +291,7 @@ fun Project.registerGenerateCargoConfigTomlTask(outputDir: File) {
                 .writeText(
                     """
                     [build]
-                    rustflags = ["--cfg", "aws_sdk_unstable"]
+                    rustflags = ["--deny", "warnings", "--cfg", "aws_sdk_unstable"]
                     """.trimIndent(),
                 )
         }

tools/ci-build/Dockerfile

@@ -205,8 +205,8 @@ ENV PATH=/opt/cargo/bin:$PATH \
     RUST_NIGHTLY_VERSION=${rust_nightly_version} \
     CARGO_INCREMENTAL=0 \
     # TODO(MSRV1.82 follow-up): Restore them once lints are fixed in the server runtime crates
-    # RUSTDOCFLAGS="-D warnings" \
-    # RUSTFLAGS="-D warnings" \
+    RUSTDOCFLAGS="-D warnings" \
+    RUSTFLAGS="-D warnings" \
     LANG=en_US.UTF-8 \
     LC_ALL=en_US.UTF-8
 # SMITHY_RS_DOCKER_BUILD_IMAGE indicates to build scripts that they are being built inside of the Docker build image.

tools/ci-scripts/check-rust-runtimes

@@ -33,7 +33,7 @@ do
 
     # TODO(MSRV1.82 follow-up): Restore `-Dwarnings` once lints are fixed in aws-smithy-http-server-python:
     # "error: unexpected `cfg` condition name: `addr_of`"
-    RUSTDOCFLAGS="--cfg docsrs" cargo +"${RUST_NIGHTLY_VERSION}" doc --no-deps --document-private-items --all-features
+    RUSTDOCFLAGS="--cfg docsrs -Dwarnings" cargo +"${RUST_NIGHTLY_VERSION}" doc --no-deps --document-private-items --all-features
 
     echo -e "## ${C_YELLOW}Running 'cargo minimal-versions check' on ${runtime_path}...${C_RESET}"
     # Print out the cargo tree with minimal versions for easier debugging